Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update super to ControlledToken in Ticket.sol #319

Merged
merged 1 commit into from
Jul 12, 2021
Merged

update super to ControlledToken in Ticket.sol #319

merged 1 commit into from
Jul 12, 2021

Conversation

kamescg
Copy link
Contributor

@kamescg kamescg commented Jul 12, 2021

@kamescg
Copy link
Contributor Author

kamescg commented Jul 12, 2021

A majority of the gas optimizations included in the code audit require not using the ProxyFactory instance pattern, since the updates would need to include a constructor function.

The only applicable update was simple to change super to ControlledToken in the Ticket.sol contract.

To update balance to a view function that would require also updating "@pooltogether/yield-source-interface/contracts/IYieldSource.sol" so we should first update the interface in that repo before making changes in the core contracts.

@kamescg kamescg merged commit c83b1b8 into master Jul 12, 2021
@kamescg kamescg deleted the fix/77 branch July 15, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants