C4 audit mitigations #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce SLOAD calls in _withdrawFromVault
gas optimization
reduce SLOAD calls in _depositInVault
fix/90 prevent locking user funds in _withdrawFromVault
fix(contract): use generic proxy factory to deploy contract
asselstine
requested changes
Jul 14, 2021
| @@ -261,7 +313,7 @@ contract YearnV2YieldSource is IYieldSource, ERC20Upgradeable, OwnableUpgradeabl | |||
| /// @dev used to calculate how many shares to mint / burn when depositing / withdrawing | |||
| /// @return tokens number of tokens equivalent (in value) to the amount of Yield Source shares | |||
| function _sharesToToken(uint256 shares) internal view returns (uint256 tokens) { | |||
| if(totalSupply() == 0) { | |||
| if (totalSupply() == 0) { | |||
There was a problem hiding this comment.
let's pull this into a variable, as it's a public function call
| @@ -248,7 +300,7 @@ contract YearnV2YieldSource is IYieldSource, ERC20Upgradeable, OwnableUpgradeabl | |||
| /// @param tokens amount of tokens to be converted | |||
| /// @return shares number of shares equivalent to the amount of tokens | |||
| function _tokenToShares(uint256 tokens) internal view returns (uint256 shares) { | |||
| if(totalSupply() == 0) { | |||
| if (totalSupply() == 0) { | |||
asselstine
approved these changes
Jul 14, 2021
asselstine
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
YearnV2YieldSourcewrong subtraction in withdraw code-423n4/2021-06-pooltogether-findings#90