update(Ticket): cast amounts to uint208 when calling TwabLib

pooltogether · Oct 6, 2021 · 0f645fb · 0f645fb
1 parent 472eefa
commit 0f645fb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/contracts/Ticket.sol b/contracts/Ticket.sol
@@ -23,7 +23,6 @@ import "./ControlledToken.sol";
 */
 contract Ticket is ControlledToken, ITicket {
     using SafeERC20 for IERC20;
-    using SafeCast for uint256;
     using ExtendedSafeCastLib for uint256;
 
     /// @notice Record of token holders TWABs for each account.
@@ -375,7 +374,7 @@ contract Ticket is ControlledToken, ITicket {
             bool tsIsNew
         ) = TwabLib.decreaseBalance(
                 totalSupplyTwab,
-                _amount,
+                _amount.toUint208(),
                 "Ticket/burn-amount-exceeds-total-supply-twab",
                 uint32(block.timestamp)
             );
@@ -456,7 +455,7 @@ contract Ticket is ControlledToken, ITicket {
             bool isNew
         ) = TwabLib.decreaseBalance(
                 _account,
-                _amount,
+                _amount.toUint208(),
                 "ERC20: burn amount exceeds balance",
                 uint32(block.timestamp)
             );

diff --git a/contracts/libraries/TwabLib.sol b/contracts/libraries/TwabLib.sol
@@ -99,7 +99,7 @@ library TwabLib {
     */
     function decreaseBalance(
         Account storage _account,
-        uint256 _amount,
+        uint208 _amount,
         string memory _revertMessage,
         uint32 _currentTime
     )
@@ -115,7 +115,7 @@ library TwabLib {
         require(_accountDetails.balance >= _amount, _revertMessage);
 
         (accountDetails, twab, isNew) = _nextTwab(_account.twabs, _accountDetails, _currentTime);
-        accountDetails.balance = (_accountDetails.balance - _amount).toUint208();
+        accountDetails.balance = _accountDetails.balance - _amount;
     }
 
     /** @notice Calculates the average balance held by a user for a given time frame.