Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Beacon: General Updates #177

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 6, 2021

POOL-1712 DrawBeacon: General Updates

  • Create internal setter for rngService
  • update DrawHistoryTransferred to DrawHistorySet event
  • Remove operator parameter from events because it's in transaction
  • Line 196 inheritdoc
  • In constructor set the rng timeout limit

Copy link
Contributor

@kamescg kamescg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - includes updates for each issue bullet point.

deploy/deploy.js Outdated
@@ -148,6 +148,8 @@ module.exports = async (hardhat) => {
});
displayResult('PrizeDistributionHistory', tsunamiDrawSettindsHistoryResult);

const rngTimout = 3600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const rngTimout = 3600
const rngTimeout = 3600

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good eye Pierrick.

deploy/deploy.js Outdated
@@ -158,6 +160,7 @@ module.exports = async (hardhat) => {
1,
parseInt('' + new Date().getTime() / 1000),
120, // 2 minute intervals
rngTimout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rngTimout
rngTimeout

@asselstine asselstine force-pushed the pool-1712-drawbeacon-general-updates branch from beabe68 to ec29071 Compare October 6, 2021 18:33
@asselstine asselstine merged commit 9aae29e into master Oct 6, 2021
@asselstine asselstine deleted the pool-1712-drawbeacon-general-updates branch October 6, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants