Interface should exclude "_" from beginning of variable names and con… #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Oct 6, 2021
contracts/DrawBeacon.sol
Outdated
| @@ -191,7 +191,7 @@ contract DrawBeacon is IDrawBeacon, Ownable { | |||
| } | |||
|
|
|||
| /// @inheritdoc IDrawBeacon | |||
| function calculateNextBeaconPeriodStartTime(uint256 currentTime) | |||
| function calculateNextBeaconPeriodStartTime(uint256 _time) | |||
There was a problem hiding this comment.
We should also update the param name in the interface.
https://github.com/pooltogether/pooltogether-contract-tsunami/blob/4b3c3f066d556076e481c4d902fe64b820c3a75d/contracts/interfaces/IDrawBeacon.sol#L107
| require(prizeSplitIndex < _prizeSplits.length, "PrizeSplit/nonexistent-prizesplit"); | ||
| require(prizeStrategySplit.target != address(0), "PrizeSplit/invalid-prizesplit-target"); | ||
| require(_prizeSplitIndex < _prizeSplits.length, "PrizeSplit/nonexistent-prizesplit"); | ||
| require(_prizeStrategySplit.target != address(0), "PrizeSplit/invalid-prizesplit-target"); |
There was a problem hiding this comment.
Should be named _prizeSplitStrategy if we want to follow the convention introduced by _prizeSplitIndex.
…tract should "_" in variable names in function interface
asselstine
force-pushed
the
pool-1655-interface-should-exclude-_-from
branch
from
4b3c3f0
to
4eec773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tract should "_" in variable names in function interface