-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EIP2612): add permitAndDepositToAndDelegate #249
Conversation
uint8 v; | ||
bytes32 r; | ||
bytes32 s; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make a 'Signature' struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 1bbaf51
bytes32 _r, | ||
bytes32 _s, | ||
PermitSignature calldata _permitSignature, | ||
DelegateSignature calldata _delegateSignature, | ||
address _prizePool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me both the _token
and _ticket
can be pulled from the PrizePool itself. It would add a few thousand gas, but make it a much simpler interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 769cfda
No description provided.