Inline assembly for number matching #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhgan
commented
Aug 23, 2021
| @@ -147,8 +147,11 @@ contract TsunamiDrawCalculator is IDrawCalculator, OwnableUpgradeable { | |||
|
|
|||
| uint256 numberOfMatches = 0; | |||
| for(uint256 matchIndex = 0; matchIndex < _masks.length; matchIndex++) { | |||
| if((uint256(_randomNumberThisPick) & _masks[matchIndex]) == (uint256(_winningRandomNumber) & _masks[matchIndex])) { | |||
| numberOfMatches++; | |||
| uint256 mask = _masks[matchIndex]; | |||
There was a problem hiding this comment.
could actually probably do this whole loop in assembly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizer on 2000 runs:
old method using high level solidity 1000 picks: 2.371M gas
this PR: 2.064M gas