Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrizeDistributionHistory: general updates #178

Merged

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 6, 2021

POOL-1711 PrizeDistributionHistory: General Updates

#21 Add natspec for max cardinality and

#23 Add natsepc for distribution ceiling

#25 Add natspec event Deployed

PrizeDistributionsSet event change name to PrizeDistributionSet

DrawRingBufferLib nextAvailableIndex to nextIndex and newestIndex applicable

Copy link
Contributor

@kamescg kamescg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - includes updates for all linear ticket bullet points.

Copy link
Contributor

@PierrickGT PierrickGT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the RingBufferLib are conflicting with this PR: #175

@asselstine asselstine force-pushed the pool-1711-prizedistributionhistory-general-updates branch from 6276dcd to c951a01 Compare October 6, 2021 18:37
@asselstine asselstine merged commit f416bb4 into master Oct 6, 2021
@asselstine asselstine deleted the pool-1711-prizedistributionhistory-general-updates branch October 6, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants