feat(PrizeDistV2): add missing events #274
Conversation
POOL-2300 Add any events to PrizeDistributorV2
Add a `Claim` event to the PrizeDistributor that emits the call data and prize amount
|
PierrickGT
force-pushed
the
pool-2300-add-any-events-to-prizedistributorv2
branch
from
ccceaf4
to
7ae2349
Compare
There was a problem hiding this comment.
This change is really funny to me. Originally the PrizeDistributor was holding tokens, so we wanted the DrawCalculator to be swappable.
Now, the PD doesn't hold tokens. It's okay if we need to swap it. However- the abstraction is bleeding now that the PD is aware of the DrawCalculator implementation: "picks".
We may as well go whole hog and update claim to take picks instead of the generic bytes data param.
contracts/DrawCalculatorV3.sol
Outdated
| ) external view override returns ( | ||
| uint256[] memory prizesAwardable, | ||
| bytes memory prizeCounts, | ||
| uint64[][] memory drawPickIndices |
There was a problem hiding this comment.
Haha this is funny!
The _pickIndicesForDraws are being passed in, decoded, then returned. Nothing else. This is like an elaborate ABI decoder.
The PrizeDistributor has no knowledge of the "picks". Originally that's because we wanted the DC to be swappable.
Returning the picks to the prize distributor means it's now aware of "picks", which completely negates the whole abstraction.
There was a problem hiding this comment.
Fixed in: 0f242fb
…-swapping-out feat(PrizeDistV2): add setTokenVault function
…-swapping fix(DrawCalcV3): set gaugeController as immutable
No description provided.