-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PrizeDistV2): add missing events #274
Merged
PierrickGT
merged 6 commits into
staging
from
pool-2300-add-any-events-to-prizedistributorv2
Jun 6, 2022
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7ae2349
feat(PrizeDistV2): add missing events
PierrickGT df30639
feat(PrizeDistV2): add setTokenVault function
PierrickGT daacfe5
fix(DrawCalcV3): set gaugeController as immutable
PierrickGT 0f242fb
fix(PrizeDistV2): pass drawPickIndices to claim
PierrickGT a19029d
Merge pull request #277 from pooltogether/pool-2303-analyze-impact-of…
PierrickGT 426e05a
Merge pull request #280 from pooltogether/pool-2302-analyze-impact-of…
PierrickGT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha this is funny!
The
_pickIndicesForDraws
are being passed in, decoded, then returned. Nothing else. This is like an elaborate ABI decoder.The PrizeDistributor has no knowledge of the "picks". Originally that's because we wanted the DC to be swappable.
Returning the picks to the prize distributor means it's now aware of "picks", which completely negates the whole abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in: 0f242fb