Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaugeController: Add Events & Natspec #276

Merged
merged 15 commits into from
Jun 1, 2022

Conversation

kamescg
Copy link
Contributor

@kamescg kamescg commented Jun 1, 2022

No description provided.

@kamescg kamescg requested a review from PierrickGT June 1, 2022 15:23
@kamescg kamescg self-assigned this Jun 1, 2022
@linear
Copy link

linear bot commented Jun 1, 2022

contracts/GaugeController.sol Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
kamescg and others added 10 commits June 1, 2022 10:44
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
Co-authored-by: Pierrick Turelier <pierrick@turelier.com>
@kamescg kamescg marked this pull request as ready for review June 1, 2022 18:02
contracts/GaugeController.sol Show resolved Hide resolved
contracts/GaugeController.sol Show resolved Hide resolved
contracts/GaugeController.sol Show resolved Hide resolved
* @notice Emitted when an Authorized User adds a new Gauge to the GaugeController
* @param gauge New Gauge address
*/
event AuthorityAddGauge(address gauge);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be renamed GaugeAdded.

@kamescg kamescg merged commit e259f46 into staging Jun 1, 2022
@kamescg kamescg deleted the pool-2293-gaugecontroller-add-events branch June 1, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants