warning: this function has too many arguments (8/7) --> cosmic-app-list/src/app.rs:169:5 | 169 | / fn as_icon( 170 | | &self, 171 | | applet: &Context, 172 | | rectangle_tracker: Option<&RectangleTracker<u32>>, ... | 177 | | dot_border_radius: [f32; 4], 178 | | ) -> Element<'_, Message> { | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> cosmic-app-list/src/app.rs:570:25 | 570 | .filter_map(|p| fs::read_to_string(&p).ok().and_then(|e| Some((p, e)))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::read_to_string(&p).ok().map(|e| (p, e))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `#[warn(clippy::bind_instead_of_map)]` on by default

warning: taken reference of right operand --> cosmic-app-list/src/config.rs:44:63 | 44 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) { | ^^^^^--- | | | help: use the right value directly: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:159:45 | 159 | players.sort_by(|a, b| a.name().cmp(&b.name())); | ^^^^^^^^^ help: change this to: `b.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:183:50 | 183 | self.players.sort_by(|a, b| a.name().cmp(&b.name())); | ^^^^^^^^^ help: change this to: `b.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> cosmic-applet-audio/src/mpris_subscription.rs:274:22 | 274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> cosmic-applet-audio/src/mpris_subscription.rs:274:35 | 274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> { | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [MprisPlayer]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> cosmic-applet-audio/src/pulse.rs:27:24 | 27 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: non-binding `let` on a future --> cosmic-applet-audio/src/lib.rs:456:25 | 456 | / _ = tokio::spawn(async move { 457 | | tokio::time::sleep(tokio::time::Duration::from_secs(30)).await; 458 | | conn.send(pulse::Message::UpdateConnection); 459 | | }); | |__________________________^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future = note: `#[warn(clippy::let_underscore_future)]` on by default