Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard-configurator backend forces static hidraw for hidapi crate #107

Closed
Conan-Kudo opened this issue Nov 14, 2021 · 1 comment · Fixed by #108
Closed

keyboard-configurator backend forces static hidraw for hidapi crate #107

Conan-Kudo opened this issue Nov 14, 2021 · 1 comment · Fixed by #108
Projects

Comments

@Conan-Kudo
Copy link

Conan-Kudo commented Nov 14, 2021

While reviewing this package for inclusion in Fedora, I noticed that it forces the linux-static-hidraw feature instead of the linux-shared-hidraw feature from the hidapi crate. In Fedora, we'd prefer that C libraries be dynamically linked for these kinds of things.

Please consider switching the requested feature of the hidapi crate to linux-shared-hidraw.

@carlwgeorge carlwgeorge added this to To do in Fedora Nov 14, 2021
@ids1024
Copy link
Member

ids1024 commented Nov 16, 2021

The hidapi crate defaults to static linking (but with libusb). But I don't see a problem with dynamic linking. Though I guess that's an extra runtime dependency for anyone trying to run ectool or keyboard-configurator from the git repos.

Too bad since Rust features are additive, there can't just be a static-hidapi or dynamic-hidapi cargo feature.

ids1024 added a commit that referenced this issue Nov 18, 2021
ids1024 added a commit that referenced this issue Nov 18, 2021
ids1024 added a commit that referenced this issue Nov 18, 2021
Fedora automation moved this from To do to Done Nov 18, 2021
jackpot51 pushed a commit that referenced this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants