Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch_(2|heavy_1) to latest firmware version #183

Merged
merged 2 commits into from May 18, 2023
Merged

Conversation

13r0ck
Copy link
Contributor

@13r0ck 13r0ck commented May 18, 2023

Related to system76/launch#86

This will need to be tested with the --launch-test flag and the embargo branch of system76 firmware added, after this is released, the keyboard firmware should be moved from embargo to release in lvfs

Keyboards should be able to install new firmware via launch test gui, and then keyboard should become availabel for configuring

@13r0ck 13r0ck requested review from a team May 18, 2023 19:09
@13r0ck
Copy link
Contributor Author

13r0ck commented May 18, 2023

I'm not sure why the windows CI test is failing, this only has changes for linux anyway, please ignore that and review anyway, this should go out as soon as possible

@n3m0-22 n3m0-22 self-assigned this May 18, 2023
n3m0-22
n3m0-22 previously approved these changes May 18, 2023
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Launch Heavy with embargo branch and --launch-test flag. Tested with locally built and installed keyboard-configurator and the appimage.

The firmware for both Launch Heavy and Launch 2 flash and are working correctly. The functionality of keyboard-configurator is working as expected as is the keyboard with both firmware.

Testing keyboard-configurator on the built in keyboards on lemp11 and gaze15 worked correctly.

Copy link
Member

@ids1024 ids1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, assuming the firmware is indeed correct and works as expected.

The CI failure on Windows is unrelated, definitely. There seems to be something non-deterministic that makes that one fail sometimes, but I don't really know how the relevant windows stuff works or if there's a better way to test it...

@13r0ck 13r0ck requested a review from n3m0-22 May 18, 2023 22:41
@13r0ck 13r0ck merged commit 0bf1596 into master May 18, 2023
20 of 21 checks passed
@13r0ck 13r0ck deleted the update-firmware branch May 18, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants