GTK Reflashing & Write Cancellation #53
Conversation
- libpopsicle was modified to enable early killing of the device flashing process - state is reset when switching back to the main view in popsicle-gtk - popsicle-gtk will revert back to the main view when: - Cancel is selected on the device flashing view - Back is selected on the summary view - popsicle-gtk GTK widgets are now Rc'd together
| authors = ["Jeremy Soller <jeremy@system76.com>"] | ||
| authors = [ | ||
| "Jeremy Soller <jeremy@system76.com>", | ||
| "Michael Aaron Murphy <michael@system76.com>", |
|
@cassidyjames asked for your review just cause there are some graphical changes (and it never hurts). |
|
It looks like the back button is marked as destructive. It doesn't need to be.
It should probably also say something like, "New Image" or something, since it's not just going back one step but is starting completely over. |
|
@cassidyjames Unless the user is not changing the image, and immediately progressing back to device selection, since the previous image is still selected at that point. In that case, should it be "Flash Again"? |
|
@mmstick that could work |
|
When canceling a write midway through, the I would imagine this should dehighlight (to look the way it does originally on the first screen). That also makes me wonder/think if that Thoughts @cassidyjames ? |
|
Functionality wise, it looks good though. Just waiting for that last commit to build... |
|
When I was showing the latest patches to @cassidyjames we noticed that the |
There was a problem hiding this comment.
To keep the forward (right) position affirmative, I think it would make sense to update it to say, "Done" on the last screen now. I know that's not strictly something that was touched in this PR, but I think with the other changes, it caused me to look a little more closely at the back/forward buttons and their copy.
|
It would also be great to update screenshots in the repo with this PR so we keep those up to date with the current UI. |
|
The summary view now says "Done", and I've fixed the next button on the device selection view. Will add new screenshots. |
|
Found an issue that can cause the device selection view to lock if select_all is enabled, and then any device is removed. Looking for the cause of the lock. |
|
Screenshots are now updated. |
There was a problem hiding this comment.
Looks good from my side of things. I'm thinking @jackpot51 should code review before we merge.
Closes #51