Add/fix missing keyboard shortcuts

[brs17]

Should fix pop-os/pop#171
Fixed Super+m (Show application menu)
Note: Removed Super+m from toggling message tray (since Super+v already does that)
Fixed Super+d (Show desktop)
Fixed Super+f (Open files)

All of these should work now: http://pop.system76.com/docs/keyboard-shortcuts/

[cassidyjames]

Looks correct, but I don't know how to test this offhand.

@jackpot51 what does the :pop do in this file? Does that only apply the override to the pop session or something?

[jackpot51]

Yep. The override is only added in the pop session.

[jackpot51]

One potential issue - home is by default set to 'Home', as some keyboards has an actual key. This would probably break that key, but I don't have a keyboard to test. @brs17 can you check that, and @cassidyjames do you think this is acceptable?

[cassidyjames]

@jackpot51 Ah yeah, I remember our ideal was being able to add both keys. If that's not supported, then I'm not sure. We should probably leave it working for the dedicated key…

[brs17]

Good catch @jackpot51. I did write over the 'Home' key. Oddly the values for media keys are strings and not string arrays so I can't add a second option. Going to play with the custom shortcuts for media keys to enable both to work.

[brs17]

So it looks like I can make a custom shortcuts by running:

gsettings set org.gnome.settings-daemon.plugins.media-keys.custom-keybinding:/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings/Files/ name "Files"

gsettings set org.gnome.settings-daemon.plugins.media-keys.custom-keybinding:/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings/Files/ command "nautilus -w"

gsettings set org.gnome.settings-daemon.plugins.media-keys.custom-keybinding:/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings/Files/ binding "<Super>f"

gsettings set org.gnome.settings-daemon.plugins.media-keys.custom-keybindings "['/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings/Files/']"

So I would do that and remove the changes I made to pop-session.gsettings-override for this shortcut.

Now I just need to figure out where to put that.

[brs17]

Ah, I probably should update the changelog as well, shouldn't I?!

[jackpot51]

I don't think the custom shortcut is going to work

[brs17]

It doesn't :(

[brs17]

Alright so I've reverted all of the Files shortcut code.

Discussing offline with @jackpot51 and @cassidyjames , we are going to remove Super+f (expected) functionality to let the file browser button work on certain external keyboards.

I am planning to file a bug upstream that the current gsetting for opening the file browser(and all media keys) should have a key value type of string array not string so that multiple values could be provided.

[WatchMkr]

Something came to mind reading this. Is it more common to have a Files/Home button on a keyboard or not? It's probably more common not to have those keys and that's certainly the case out of the percentage of keyboards we ship. If that's the case, is it better to set Super+F for files and a customer can use Keyboards shortcuts if they have the key and want to set it? It's a pretty obvious setting.

[brs17]

That's a good point.

My first thought that comes to mind is that by doing this we would be actively breaking functionality for people who do have a keyboard with it (the Amazon Basics keyboard does have the key). Seeing that this functionality has not worked in the lifetime of Pop!_OS my thought is we shouldn't now rush to do something that breaks functionality.

I think if we can get upstream to agree to accept multiple shortcuts for multimedia keys, that'd be the best way to implement both. Otherwise if we really want this feature, doing it ourselves would also be an option.

[jackpot51]

Merge when ready @brs17