Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop Shell breaks Activities on Pop!_OS and Ubuntu 20.04 LTS #1072

Closed
whyd0t opened this issue Jul 9, 2021 · 29 comments · Fixed by #1085
Closed

Pop Shell breaks Activities on Pop!_OS and Ubuntu 20.04 LTS #1072

whyd0t opened this issue Jul 9, 2021 · 29 comments · Fixed by #1085
Assignees

Comments

@whyd0t
Copy link

whyd0t commented Jul 9, 2021

(1) Issue/Bug Description:
Shell seems to "break" Ubuntu Activities. When pop shell is enabled and I go to Activities overview by pressing Super or Clicking the top left, I can't exit out again program windows disappear. I haven't had this issue before, it happened yesterday with a fresh Ubuntu install. The only way to exit back to the desktop; is by logging out and in again or using ALT+F2 and run r to restart.

(2) Steps to reproduce (if you know):
Enable pop shell and go to Activities overview.

(3) Expected behavior:
Cannot exit Activities and cannot see Workspaces.

(4) Distribution (run cat /etc/os-release):
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"

(5) Gnome Shell version:
3.36.8

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

(7) Where was Pop Shell installed from:
Git clone.

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):
Single laptop monitor (Lenovo T490s)

(9) Other Installed/Enabled Extensions:
None.

@whyd0t whyd0t closed this as completed Jul 9, 2021
@whyd0t whyd0t reopened this Jul 9, 2021
@AxcellF
Copy link

AxcellF commented Jul 12, 2021

Not sure if this is helpful, but anyways:

I've experienced the same issue on a XPS 9560 and a VM (both running Ubuntu 20.04.2 LTS). Made sure to remove all other gnome extensions which didn't make any difference.

@jixbo
Copy link

jixbo commented Jul 13, 2021

I am also affected by this issue since I updated to the latest commit, to fix the VLC full screen issue #942.
I'm using Ubuntu 21.04 and wayland, and everything was working fine before with the older shell extension. What commit are you on @d0tsaint ?
I'm on the latest from master, f4894c8.

@whyd0t
Copy link
Author

whyd0t commented Jul 13, 2021

I'm also on the latest commit and now running Ubuntu 21.04 instead of LTS. It keeps happening periodically and the only fix I've found is to use X11 instead of Wayland, so I can make a quick restart.

@jixbo
Copy link

jixbo commented Jul 13, 2021

Here are the logs of the issue:

gnome-shell[54799]: JS ERROR: Exception in callback for signal: trigger: too much recursion
                                             _show_skip_taskbar_windows/Workspace.prototype._isOverviewWindow@/home/jixbo/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2003:13
                                             _show_skip_taskbar_windows/Workspace.prototype._isOverviewWindow@/home/jixbo/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2004:17
                                             ... (same line many more times)
gnome-shell[54799]: Can't update stage views actor StBin is on because it needs an allocation.
gnome-shell[54799]: JS ERROR: TypeError: this._workspacesViews[index] is undefined
                                             _init/<@resource:///org/gnome/shell/ui/workspacesView.js:374:1

Here is the full log file

@Scarzer
Copy link

Scarzer commented Jul 13, 2021

I'm having the same issues, but my logs seem to be showing something different that what @jixbo has.

JS ERROR: TypeError: proxy._proxyChangedProperties is undefined
refreshPropertyOnProxy/<@/usr/share/gnome-shell/extensions/ubuntu-appindicators@ubuntu.com/util.js:81:17

JS ERROR: TypeError: meta_window.get_wm_class is not a function
skiptaskbar_shall_hide@/home/irv/.local/share/gnome-shell/extensions/pop-shell@system76.com/config.js:85:35
_show_skip_taskbar_windows/Workspace.prototype._isOverviewWindow@/home/irv/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2002:36
_init@resource:///org/gnome/shell/ui/workspace.js:1173:22
_updateWorkspaces@resource:///org/gnome/shell/ui/workspacesView.js:232:29
_init@resource:///org/gnome/shell/ui/workspacesView.js:91:14
_updateWorkspacesViews@resource:///org/gnome/shell/ui/workspacesView.js:682:24
show@resource:///org/gnome/shell/ui/workspacesView.js:612:14
show@resource:///org/gnome/shell/ui/viewSelector.js:276:33
_animateVisible@resource:///org/gnome/shell/ui/overview.js:580:27
show@resource:///org/gnome/shell/ui/overview.js:566:14
toggle@resource:///org/gnome/shell/ui/overview.js:689:18
_initializeUI/<@resource:///org/gnome/shell/ui/main.js:223:22

Received error from D-Bus search provider org.gnome.seahorse.Application.desktop during GetResultMetas: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.gnome.Shell.SearchProvider2” on object at path /org/gnome/seahorse/Application
Wrong number of result metas returned by search provider org.gnome.seahorse.Application.desktop: expected 1 but got 0
Window manager warning: META_CURRENT_TIME used to choose focus window; focus window may not be correct.
Object Meta.BackgroundActor (0x55d85b548700), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
== Stack trace for context 0x55d85863b910 ==
#0   7fff841fcb70 b   resource:///org/gnome/gjs/modules/core/overrides/GObject.js:571 (3b887d1b6c40 @ 25)
#1   55d8589a9238 i   /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:209 (3763f802a3d0 @ 85)
#2   55d8589a91b0 i   /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:148 (3763f802a1f0 @ 12)
#3   55d8589a9128 i   resource:///org/gnome/shell/ui/main.js:236 (3b887d1d5e98 @ 12)
JS ERROR: Error: Argument 'instance' (type interface) may not be null
_init/GObject.Object.prototype.disconnect@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:571:24
_onDestroy@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:209:45
_init/<@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:148:44
_initializeUI/<@resource:///org/gnome/shell/ui/main.js:236:16

Object Meta.BackgroundActor (0x55d85b548ad0), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
== Stack trace for context 0x55d85863b910 ==
#0   7fff841fcb70 b   resource:///org/gnome/gjs/modules/core/overrides/GObject.js:571 (3b887d1b6c40 @ 25)
#1   55d8589a9238 i   /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:209 (3763f802a3d0 @ 85)
#2   55d8589a91b0 i   /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:148 (3763f802a1f0 @ 12)
#3   55d8589a9128 i   resource:///org/gnome/shell/ui/main.js:236 (3b887d1d5e98 @ 12)
JS ERROR: Error: Argument 'instance' (type interface) may not be null
_init/GObject.Object.prototype.disconnect@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:571:24
_onDestroy@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:209:45
_init/<@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:148:44
_initializeUI/<@resource:///org/gnome/shell/ui/main.js:236:16


For completeness I'm running this on Ubuntu 20.04.
Gnome Shell Version 3.36.9
Pop shell Version 1.1.0~1625582124~20.04~3873fc5

@jacobgkau jacobgkau changed the title Pop Shell breaks Ubuntu Activities Pop Shell breaks Activities on Pop!_OS and Ubuntu 20.04 LTS Jul 13, 2021
@jacobgkau
Copy link
Member

I am seeing this on Pop!_OS and Ubuntu 20.04. I believe the relevant portion of the logs is the section that appears at the time Activities is opened:

Jul 13 11:13:40 pop-os gnome-shell[2512]: JS ERROR: TypeError: meta_window.get_wm_class is not a function
                                          skiptaskbar_shall_hide@/usr/share/gnome-shell/extensions/pop-shell@system76.com/config.js:85:35
                                          _show_skip_taskbar_windows/Workspace.prototype._isOverviewWindow@/usr/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2002:36
                                          _init@resource:///org/gnome/shell/ui/workspace.js:1173:22
                                          _updateWorkspaces@resource:///org/gnome/shell/ui/workspacesView.js:232:29
                                          _init@resource:///org/gnome/shell/ui/workspacesView.js:91:14
                                          _updateWorkspacesViews@resource:///org/gnome/shell/ui/workspacesView.js:682:24
                                          show@resource:///org/gnome/shell/ui/workspacesView.js:612:14
                                          show@resource:///org/gnome/shell/ui/viewSelector.js:276:33
                                          _animateVisible@resource:///org/gnome/shell/ui/overview.js:580:27
                                          show@resource:///org/gnome/shell/ui/overview.js:566:14
                                          toggle@resource:///org/gnome/shell/ui/overview.js:689:18
                                          vfunc_event@resource:///org/gnome/shell/ui/panel.js:482:31

meta_window.get_wm_class is called in code that was added in dc0e306, the final commit in #1069.

@jacobgkau
Copy link
Member

@jixbo The issue you're experiencing seems like a different problem since you're on 21.04 and Wayland, although your "full log file" is only a snippet, and I don't have enough information to recreate it. I'm not seeing the issue on Ubuntu 21.04 with Wayland after installing VLC (which you mentioned) and Sleek, which is a "skip taskbar window." Can you confirm if this branch stops the issue on your machine? Any information about other applications and shell extensions you have running might also be helpful.

@jixbo
Copy link

jixbo commented Jul 13, 2021

@jacobgkau thanks for the fast response.

Here you can find the full gnome-shell logs of today. The issue happened a few times, last one at 21.50, just after the laptop came back from suspension.
VLC is not related to this issue at all, but #942 was the reason I updated to the latest commit, but that problem is now gone.

I'm getting this issue with "Activities" with no special application, after using the computer for a long time. It does not happen the first few times "Activities" gets triggered. It can happen triggering activities either with the mouse gesture on the corner, or the meta key. Today I was using telegram, google-chrome, visual studio and spotify.

I'll test the latest fix and report back, thank you.

@jtmackoy
Copy link

jtmackoy commented Jul 14, 2021

Stumbled upon this issue when I encountered this problem. For anyone else, I've found that simply restarting gnome via ALT + F2 and entering r then pressing Enter will get me out of the Activities overview with no ill effects.

That said, I'm now watching this thread to see how the problem is ultimately resolved.

@whyd0t
Copy link
Author

whyd0t commented Jul 14, 2021

@jtmackoy That's my solution too. Unfortunately you can't restart shell with ALT + F2, r if you are running Wayland.

@jtmackoy
Copy link

New info - just discovered that if I uninstall (make uninstall) then checkout commit 3873fc5bbe84c392d1ed424760dc6134aafcbced and reinstall (make local-install), the problem goes away.

@jacobgkau
Copy link
Member

New info - just discovered that if I uninstall (make uninstall) then checkout commit 3873fc5bbe84c392d1ed424760dc6134aafcbced and reinstall (make local-install), the problem goes away.

Yes, that commit is before dc0e306, which is the one that added the problematic function call.

@jtmackoy
Copy link

Apologies @jacobgkau - missed that detail in your earlier comment.

@jixbo
Copy link

jixbo commented Jul 14, 2021

After the whole day using the latest fix from #1080 (latest version on master branch) , the problem didn't reoccur.
I'm pretty confident the issue is fixed, because it happened several times yesterday with a similar usage.

Thanks everyone, specially @jacobgkau for the quick support.

@jacobgkau
Copy link
Member

jacobgkau commented Jul 14, 2021

@jixbo Glad to hear the 21.04 is fixed after that PR. Thank you for confirming. This issue remains open for the 20.04 issue, which is separate.

@ids1024 ids1024 self-assigned this Jul 14, 2021
ids1024 added a commit that referenced this issue Jul 14, 2021
It seems in 3.38, the argument to this function was changed from the
`MetaWindowActor` to the `MetaWindow`. This adds a test to correctly get
the `MetaWindow` on both 3.36 and 3.38.

This should fix #1072.
ids1024 added a commit that referenced this issue Jul 14, 2021
It seems in 3.38, the argument to this function was changed from the
`MetaWindowActor` to the `MetaWindow`. This adds a test to correctly get
the `MetaWindow` on both 3.36 and 3.38.

This should fix #1072.
ids1024 added a commit that referenced this issue Jul 14, 2021
It seems in 3.38, the argument to this function was changed from the
`MetaWindowActor` to the `MetaWindow`. This adds a test to correctly get
the `MetaWindow` on both 3.36 and 3.38.

This should fix #1072.
@cb3inco
Copy link

cb3inco commented Jul 15, 2021

Just ran into this issue also - Alt - F2 R seems to be the only solution at the moment:

Darter Pro 6
Pop!_OS 20.04
Gnome: 3.36.8
Windows System: X11

pop-shell:
Installed: 1.1.0162620371620.04021c931
Candidate: 1.1.0
162620371620.04021c931
Version table:
*** 1.1.0162620371620.04~021c931 1001
1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main amd64 Packages
1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main i386 Packages
100 /var/lib/dpkg/status

Getting the same log error as mentioned by @jacobgkau

@redromnon
Copy link

Encountering the same exact problem as explained by @d0tsaint at the beginning. Hope it gets resolved soon...

@redromnon
Copy link

Encountered this issue right after a system update...

@romen
Copy link

romen commented Jul 15, 2021

For the record, this workaround for 20.04 seems to be working:
https://www.reddit.com/r/pop_os/comments/okfdvh/cant_get_out_of_activates_after_update/h58q94r/

jacobgkau pushed a commit that referenced this issue Jul 15, 2021
It seems in 3.38, the argument to this function was changed from the
`MetaWindowActor` to the `MetaWindow`. This adds a test to correctly get
the `MetaWindow` on both 3.36 and 3.38.

This should fix #1072.
@jacobgkau
Copy link
Member

A fix for this (#1085) has been merged. It will take some time to build and get released from proposed, but it should be available within a few hours.

@jacobgkau
Copy link
Member

jacobgkau commented Jul 15, 2021

The fix is now published, 20.04 users can apply all updates and then restart GNOME Shell or reboot to get the fix. (To install updates without the Activities menu, use the Pop Shell launcher with Super+/ to open a terminal or the Pop!_Shop.)

@AlexandreCamillo
Copy link

The fix is now published, 20.04 users can apply all updates and then restart GNOME Shell or reboot to get the fix. (To install updates without the Activities menu, use the Pop Shell launcher with Super+/ to open a terminal or the Pop!_Shop.)

I've just done it and fixed the problem!! Thanks!

@romen
Copy link

romen commented Jul 15, 2021

@jacobgkau it seems there might be some minor issue pending, even after the updated package: https://chat.pop-os.org/pop-os/pl/poxuysakzjr5be5ypmsk4xtx5y

@redromnon
Copy link

The fix is now published, 20.04 users can apply all updates and then restart GNOME Shell or reboot to get the fix. (To install updates without the Activities menu, use the Pop Shell launcher with Super+/ to open a terminal or the Pop!_Shop.)

Finally! Just installed the latest Pop Shell update, works flawlessly now!

@zhfish
Copy link

zhfish commented Jul 16, 2021

good job

@e3b0c442
Copy link

e3b0c442 commented Jul 17, 2021

Unfortunately this is not 100% resolved for me. I'm still seeing instances where the Activities menu is unresponsive during/after opening Battle.net client in Wine via Lutris. Disabling the "Show Minimize to Tray Windows" setting seems to be a usable workaround for now.

Fully up-to-date 20.04, single 1080P monitor in landscape, no additional extensions or changed settings from stock.

@vhakulinen
Copy link

vhakulinen commented Jul 24, 2021

This is still happening on my system after I start and login to steam (popos 20.04, all updates installed).

Doing the Alt + F2 and r command couple of times seems to "fix" it.

@danilopinotti
Copy link

danilopinotti commented Jul 31, 2021

This is still happening on my system after I start and login to steam (popos 20.04, all updates installed).

Doing the Alt + F2 and r command couple of times seems to "fix" it.

It stills happens here too...
Pop!_OS Shell Version: 1.1.0~1627383380~20.04~475b49d (updated today)

@vhakulinen
Copy link

vhakulinen commented Aug 2, 2021

FWIW, in the past few days, this hasn't been happening that often anymore. Seems to be more random now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.