fix: handle gjs in 3.36 #1131
Merged
fix: handle gjs in 3.36 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think Github needs a confirm dialog when cleaning up branches. I re-opened the PR |
jacobgkau
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Confirmed this fixes the stray gjs icon in Activities, recreated by installing the WindowOverlay Icons extension on a 20.04 LTS system.
Regression testing passed:
shell-pr1131-hirsute.txt
shell-pr1131-focal.txt
|
Sorry, I forgot to mention that this does not fix #1094, so it should not be closed by this PR. |
|
I removed the ticket 1094. I thought the emulator was its own window (not transient with) from the IDE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056