Pop!_Shop categories are broken when using default GNOME theme

[tosziro]

Distribution (run cat /etc/os-release):
NAME="Pop!_OS"
VERSION="20.04 LTS"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME):
Pop!_Shop

Issue/Bug Description:

Categories looks very bad when using default GNOME theme - Adwaita.

Expected behavior:

Clean looking categories

Other Notes:

Could you please guys fix this??

[simonsaysthis]

Might be trivial to some but its the reason I don't use Pop anymore. I just want the store to work with Adwaita.

[cassidyjames]

We could ship fallback color definitions in the styles, so it would work in any stylesheet—as long as the system stylesheet can still override those color definitions.

[simonsaysthis]

Thank you @cassidyjames that would be wonderful

[morgenman]

Excited to have this fixed

[simonsaysthis]

We could ship fallback color definitions in the styles, so it would work in any stylesheet—as long as the system stylesheet can still override those color definitions.

Thanks again for fixing this so quickly

[morgenman]

This is fixed? I just updated my system and it was still broken.

[TechnologyMan101]

Well, it got fixed at least on my computer although the Finance icon is broken because I'm using Papirus icons. For my theme, I'm using Matcha-light-azul. See screenshot below.

[morgenman]

Did you build from source? I was waiting for it to get pushed to my pc automatically, but maybe you did it manually?

[morgenman]

Yea just tested, works for matcha, none of my other themes (even adwaita)
Looked into matcha theme, it appears to have support for elementary app center (which is what popshop is forked from). Not sure why it wasn't working before.

[TechnologyMan101]

Yeah, matcha before I updated it basically two days ago to fix a problem with the power menu (I installed it on Friday originally from GitHub) failed in Pop!_Shop. Now it works. Weird. I just tested with Adwaita and it fails. I guess we have to wait until the System76 teams pulls the update from Elementary.

EDIT: Maybe Matcha now works for me because I installed it to /usr/share/themes instead of ~/.themes this time.

[morgenman]

My theme pulls from /usr/share/themes too. I honestly think matcha just planned to support elementary.

[morgenman]

I fixed this on my machine by following jnsh's advice on this issue:
jnsh/arc-theme#83

[TechnologyMan101]

I guess we'll have to wait for someone to create a pull request bringing in the changes. Also, icons really should have a fallback option too as the finance icon breaks when using another icon theme.

[morgenman]

Yea, there's a ton of icons that don't work for me. A generic fallback theme would be good.

…

On Thu, Oct 1, 2020, 10:54 AM TechnologyMan101 ***@***.***> wrote: I guess we'll have to wait for someone to create a pull request bringing in the changes. Also, icons really should have a fallback option too as the finance icon breaks when using another icon theme. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#215 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2X6HXMNEZJ5G2JWVPACCDSISJ27ANCNFSM4QYO6JCA> .

[TechnologyMan101]

Can you create a new issue for this? I think that the fallback icons should be from the Pop icons.

I'm really busy and I can't even maintain my own GitHub stuff on time.