-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serval keyboard backlights #36
Conversation
Hello, just checking in here... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all tests pass from QA, I approve
I have a servalWS and this fixes my keyboard backlight detection in Arch Linux. |
galp3 needs this fix as well, see #45 |
Ping? |
It occurred to me after running into a similar issue of no one merging a PR on another project... @jackpot51, you are aware that a repo owner has to merge it in right? I can't do that. |
@withinboredom yes... I am waiting for @pop-os/quality-assurance approval still
|
Apologies on this one dragging on for so long. Our serw11 lab unit had a GPU failure just a few months before this PR was opened, so we haven't had the hardware to test this. I was planning on waiting until it was fixed, but we've been unable to find a replacement GPU, and my hope of ever finding one is pretty much gone. What I'd like to do is ask everyone who tested this PR on their own serw11 to give me a 👍 on this comment. If the number reassures me, I will bypass standard testing policy and approve it without my own testing. |
@leviport fwiw, most people probably aren't experiencing any issues with this module not being loaded. You'd only notice you have an issue if you tried hooking into the keyboard backlights. Also, I think it might affect power consumption (I don't remember all the details of this kernel module). I don't know all the ins-and-outs of things (or if this is even doable), but it might be easier to just push a firmware update that sets the bios vendor to System76 instead of American MegaTrends. It seems a lot less riskier to do it that way IMHO. If there's some way to downgrade to a previous firmware, I can try that on my machine and see if the previous vendor was System76 as well (just to double-check that that is the issue). |
I just wanted to point out the current patch doesn't have the galp3 fix. just in case |
I got my serw11 back, so I'll review this soon. |
Update: my serw11 started misbehaving again (unrelated to this PR, of course). Sorry, but I have to figure out what its problem is before I can finish testing this PR. |
It does seem like we're one of the few people with this issue that cares about setting the keyboard backlight through a script. I was able to get this working by compiling your changes, but it's a hassle because I have to do it every time Arch updates the kernel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed on our lab serw11, restores software control of the keyboard backlight (as reported) with no regressions in other functionality.
justs like #36 on galp3 the system fails to load the module, and the fix works as well.
I maintain https://github.com/withinboredom/system-76-keyboards, and have a Serval. Anyway, about 6 months ago, it stopped working which coincided with a firmware update. I was sad because I thought it was the firmware update.
Tonight I decided to try and discover if I could get them back. I stumbled across this repo and then went through the history to try and discover what happened; plus my dmi table. Here's the output from
dmidecode
:You will note that the bios vendor is not
System76
, butAmerican Megatrends
(so it might be that firmware update afterall 🤔). Anyway, it fails the check inDMI_TABLE_LEGACY
, I changed it toDMI_TABLE
and the module actually gets loaded and everything works again.