Base & mobile modules revision #76

vzamanillo · 2016-11-16T16:20:40Z

Butterknife update
Picasso improvements
New response treatment for providers API (with jackson, removed slow GSON)
Other Java language fixes.

Simplified logic. Fixed dereference of 'channel' may produce 'java.lang.NullPointerException'.

Removed unneded try

Moved to a public static variable

vzamanillo · 2016-11-16T16:42:32Z

A question, Who is the API owner?

ChrisAlderson · 2016-11-16T16:44:12Z

Guess I am, I developed it.

vzamanillo · 2016-11-16T17:03:37Z

The common per quality torrent includes seeds and peers but there are an inconsistency with movies, for movies are seedand peer thats we have to extend the torrent per quality object and override the getter for both properties.

If we are the API owners the reponse and entity treatmen for each provider could be simplified a lot, we should not need formatListForPopcornor formatDetailForPopcorn methods anymore, I think we could work with the same models, not for Android app only, for desktop too.

I can contribute with the API backend to do some improvements if you need some help, I am not a good frontend developer, but I am very experienced with backend development.

ChrisAlderson · 2016-11-16T17:20:30Z

At the time of developing the API I didn't touch the android or desktop version, so in order to keep those working I ended up using the old value names. Now I'm fine with changing it for consistency reasons.

vzamanillo · 2016-11-16T17:26:49Z

Thank you, Chris, first step should be change the seed and peer json properties for movies to unify it with the other providers, we can think about the model refactorization process later.

ChrisAlderson · 2016-11-16T17:27:48Z

Two files would need to be changed:

And the current field names in the MongoDB database would need to be updated.

vzamanillo · 2016-11-16T17:29:50Z

Great!! tell me when we are in production to modify both, desktop and Android applications.

API mod PR ready

vzamanillo · 2016-11-16T17:32:20Z

This PR fixes #65 too, and probably others...

square/picasso#1185

Member variables to local. Removed deprecated methods.

To solve the load of not initialized fragments on change genre we always load the results because does not affect performance and ensure that the movies with that genre are loaded into the MediaListFragment when we clicked on the navigation item

vzamanillo · 2016-11-18T18:58:14Z

I announce that we have an Android mobile version almost usable 😊

…odified acceses

MrRory · 2016-11-22T19:48:34Z

base/src/main/java/butter/droid/base/ButterApplication.java

        LeakCanary.install(this);
        Foreground.init(this);

        //initialise logging
-        if (BuildConfig.DEBUG) {
+        if (debugable || BuildConfig.DEBUG) {


not totally sure, but the debuggable flag manages BuildConfig.DEBUG so this would be double checking the same thing

I think that BuildConfig.DEBUG has no effect at Android Studio debugging runtime.

According to this BuildConfig.DEBUG should be enough

MrRory · 2016-11-22T19:53:34Z

I was halfway when I decided that I'm not even going to look at it all. If it works, then 👍 wow. Some refactoring was really needed

MrRory · 2016-11-22T20:05:41Z

btw, i saw that butter moved forward with using dagger. maybe there is some way to merge it somewhere? not really easy i guess

vzamanillo · 2016-11-22T21:50:31Z

This is impossible to merge, I am afraid of we have to do it manually, dagger and OkHttp 3.

vzamanillo added 30 commits November 4, 2016 15:29

First Android Studio cleanup

729e846

Removed unused imports

3610871

Class structure, fields can be local

ecc564f

Simplified equals() return

bf80bd5

Java language level migration aids

1402dd5

Fixed Javadoc issues

990e495

Redundant initializer

6e693ba

Removed redundant initializers

201e364

Not annotated method overrides method annotated with @nonnull

f7f0174

Performance issues StringBuilder can be replaced with String

202730f

Statements with empty body

4a07508

argsValues is never null

a28f481

Improved updater

683297a

Simplified logic. Fixed dereference of 'channel' may produce 'java.lang.NullPointerException'.

Fixed getPath() may produce 'java.lang.NullPointerException'

36a17bb

Removed unneded try

Fixed ignored method results

cbf8af1

Use "L" to indicate a long value

c6b8e4f

oneway to interface method

0c35c3c

Removed redundant character escape

b1114f8

Redundant variable declaration

74be749

Declaration acces can be weaker, changed to private

e3a23da

Redundant and unused throws clause

9dd73c4

Fixed Javadoc after redundant and unused throws clause fixes

2d61283

Return value of the methods are never used, fixed Javadoc

edb2e70

Remove unnecessary throws declarations

84550ff

Method always return 1

2e65897

Moved to a public static variable

CPU_ABI is deprecated, aded compat util classes

faa208c

Fixes for locale deprecation

eea1ea6

Fixes for getAllNetworkInfo() deprecation

a3f134e

Simplified return

b927b91

Fix for Settings.System.ANDROID_ID deprecation

979daa1

vzamanillo added 10 commits November 16, 2016 20:32

Removed the placeholder due to unexpected results on scrolling

f52e332

debugable != BuildConfig.DEBUG, fixed cacheSize type, increased cache

2e9ce0d

Removed unused import

2053db5

Removed the custom downloader for Picasso due to cache troubles

f4150e5

square/picasso#1185

Each provider uses an own tag for request instead of the default

e33ca0f

Each provider cancels their own requests

5571a90

We clear old items before change genere.

5a84c1b

Member variables to local. Removed deprecated methods.

Force the getMediaCallTag method impl for all MediaProvider subclasses

eb931a8

Fixed deprecation

2408f02

Fix #20 Removed genre comparision

f8bc63b

To solve the load of not initialized fragments on change genre we always load the results because does not affect performance and ensure that the movies with that genre are loaded into the MediaListFragment when we clicked on the navigation item

Removed GSON reference

8dd4e2a

ChrisAlderson mentioned this pull request Nov 19, 2016

seed to seeds and peer to peers for Movies popcorn-official/popcorn-api#54

Closed

vzamanillo added 2 commits November 20, 2016 18:35

Fixed onAttach(Activity activity) deprecation warning

4d5f53a

Simplified isLoading return, fixed getPosition deprecation warning, m…

9591ce6

…odified acceses

MrRory reviewed Nov 22, 2016

View reviewed changes

vzamanillo mentioned this pull request Nov 24, 2016

[Feature Request] App Shortcuts and Circular Icon for Android 7.1+ butterproject/butter-android#109

Closed

team-pct merged commit 1d44d47 into popcorn-official:development Nov 24, 2016

kiriles90 removed this from Done in Popcorn Time Android Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Base & mobile modules revision #76

Base & mobile modules revision #76

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016

ChrisAlderson commented Nov 16, 2016

vzamanillo commented Nov 16, 2016 •

edited

Loading

ChrisAlderson commented Nov 16, 2016

vzamanillo commented Nov 16, 2016

ChrisAlderson commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 18, 2016

MrRory Nov 22, 2016

vzamanillo Nov 22, 2016

MrRory Nov 23, 2016

MrRory commented Nov 22, 2016

MrRory commented Nov 22, 2016

vzamanillo commented Nov 22, 2016 •

edited

Loading

Base & mobile modules revision #76

Base & mobile modules revision #76

Conversation

vzamanillo commented Nov 16, 2016 • edited Loading

vzamanillo commented Nov 16, 2016

ChrisAlderson commented Nov 16, 2016

vzamanillo commented Nov 16, 2016 • edited Loading

ChrisAlderson commented Nov 16, 2016

vzamanillo commented Nov 16, 2016

ChrisAlderson commented Nov 16, 2016 • edited Loading

vzamanillo commented Nov 16, 2016 • edited Loading

vzamanillo commented Nov 16, 2016 • edited Loading

vzamanillo commented Nov 18, 2016

MrRory Nov 22, 2016

Choose a reason for hiding this comment

vzamanillo Nov 22, 2016

Choose a reason for hiding this comment

MrRory Nov 23, 2016

Choose a reason for hiding this comment

MrRory commented Nov 22, 2016

MrRory commented Nov 22, 2016

vzamanillo commented Nov 22, 2016 • edited Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

ChrisAlderson commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 16, 2016 •

edited

Loading

vzamanillo commented Nov 22, 2016 •

edited

Loading