Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes and Quality iof Life changes #1452

Closed
wants to merge 1 commit into from

Conversation

rapito
Copy link

@rapito rapito commented May 3, 2020

- Place Downloaded files on their own directory, based on the season/episode, defaults to torrent hash if torrent is dropped
- Fix Default Settings to set default language to "en", turn off vpn, and automaticUpdating=off
- Fix Subtitles selection when choosing a movie
@team-pct
Copy link
Contributor

team-pct commented May 3, 2020

Can one of the admins verify this patch?

@team-pct
Copy link
Contributor

team-pct commented May 3, 2020

Why turn off automaticupdating ?

@rapito
Copy link
Author

rapito commented May 4, 2020

Automatic update often break stable build on people systems. I.e:
https://www.reddit.com/r/PopCornTime/comments/fk4qqh/previous_version/

It should be off by default and people should choose whether to update or not.

This is not apple or microsoft to force people to do stuff.

@team-pct
Copy link
Contributor

team-pct commented May 4, 2020

I understand that this is not Microsoft but then we will still have people asking why they are not getting updates ...

@rapito
Copy link
Author

rapito commented May 4, 2020

Well... There are no people asking for updates on reddit but they are complaining about builds that break stuff.

There's no need for updates if things are working ok. Whoever needs one would come in and download it.

A better approach for updates is a confirm dialog rather than a mandatory update. Asking the person to update when the app is started if there is a new version. But only update if the user confirms.

@team-pct
Copy link
Contributor

team-pct commented May 4, 2020

Yes on this i agree , updater should be rewritten i will take a look to notify first without installing the updating

@test2a
Copy link

test2a commented May 26, 2020

What if there is a check for updates before download updates ? That way we can have auto download off by default but check for updates on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants