Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1541, relative path require fail on Ubuntu 20.04 #1546

Closed
wants to merge 3 commits into from

Conversation

blaze33
Copy link

@blaze33 blaze33 commented Jul 2, 2020

cf . #1541

For some (still unexplained) reason, in bootstrap.js, relative imports ie. require("./some-relative-path") fail.

This PR fixes the issue in two ways:

  1. Avoiding the import altogether: require('../../package.json') is replaced by nw.App.manifest.
  2. Rewriting relative path to absolute ones.

@blaze33
Copy link
Author

blaze33 commented Nov 24, 2020

As explained in #1541 (comment) the relative ../package.json import only fails when special characters are in the import path. Not sure how to handle this case apart from moving PCT files to a folder path with no special characters.

Considering you say #1784 conflicts with this PR, I'm okay with you closing it.

@popcorn-official popcorn-official deleted a comment from Persei08 Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants