Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve devDependencies for root package #4

Merged
merged 4 commits into from
Jun 20, 2014
Merged

Conversation

sorrycc
Copy link
Collaborator

@sorrycc sorrycc commented Jun 19, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) when pulling a6025ba on sorrycc:master into 8bb56dc on popomore:master.

if (!father) {
extend(deps, pkg.spm.devDependencies);
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

虽然这样实现比较简单,但我还是希望将 devDependencies 独立处理出来,合在依赖中很奇怪

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放在 _parsePkgDeps 里合?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 41cca62 on sorrycc:master into 8bb56dc on popomore:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling ac1e472 on sorrycc:master into 8bb56dc on popomore:master.

@popomore
Copy link
Owner

+1

popomore added a commit that referenced this pull request Jun 20, 2014
resolve devDependencies for root package
@popomore popomore merged commit dfda566 into popomore:master Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants