fix: add a dialog for delete and edit #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to use a new widget for delete and edit of the note. The previous approach was to use the context of `NoteSheet` for showing indicators or routing. The approach does not work well for some cases because the operation deletes the note `NoteSheet` is watching for, and the context is unmounted before pushing to the post page. With this PR, adding `DeleteAndEditDialog`, a separate context is used during delete and edit so that the context will not be unmounted.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use a new widget for delete and edit of the note.
The previous approach was to use the context of
NoteSheetfor showing indicators or routing.The approach does not work well for some cases because the operation deletes the note
NoteSheetis watching for, and the context is unmounted before pushing to the post page.With this PR, adding
DeleteAndEditDialog, a separate context is used during delete and edit so that the context will not be unmounted.