Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of numpy strings for deme names #505

Merged
merged 1 commit into from Apr 3, 2023

Conversation

grahamgower
Copy link
Member

Closes #495

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d28db30) 99.81% compared to head (0eefa86) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files           5        5           
  Lines        1595     1597    +2     
=======================================
+ Hits         1592     1594    +2     
  Misses          3        3           
Impacted Files Coverage Δ
demes/demes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grahamgower grahamgower merged commit 8b76542 into popsim-consortium:main Apr 3, 2023
15 checks passed
@grahamgower grahamgower deleted the numpy-str branch April 3, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on dict conversion if using numpy.str_
2 participants