Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a backend argument? #133

Closed
petrelharp opened this issue Oct 8, 2019 · 4 comments
Closed

add a backend argument? #133

petrelharp opened this issue Oct 8, 2019 · 4 comments

Comments

@petrelharp
Copy link
Contributor

I think that we'll want to be able to specify which backend to use, once we have the ability to use a SLiM backend.

@grahamgower
Copy link
Member

There will also need to be a way to specify backend specific parameters. It will get a little messy if they're all thrown in cli.py: top_parser. I propose that there be a Backend class, with an add_backend() method, so that various backend specific things can be specified (like currently exists for species or models). At a minimum, a backend would have a name, an empty list of CLI args, and implement a simulate function that follows the msprime.simulate API.

@jeromekelleher
Copy link
Member

I agree we'll need a generic interface for the simulation engines (is "backend" a big vague?). Your ideas here seem very logical to me.

@grahamgower
Copy link
Member

SimulationEngine is fine too.

@andrewkern
Copy link
Member

closing this down as I believe #187 resolves this issue. feel free to reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants