Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC for HelMel species #1165

Merged
merged 1 commit into from
Feb 16, 2022
Merged

QC for HelMel species #1165

merged 1 commit into from
Feb 16, 2022

Conversation

noscode
Copy link
Contributor

@noscode noscode commented Jan 12, 2022

It includes updated chromosome lengths and generation time.

For more information see Issue #880.

@noscode noscode mentioned this pull request Jan 12, 2022
11 tasks
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1165 (8cd25c3) into main (33d5e2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          95       95           
  Lines        3148     3148           
  Branches      413      413           
=======================================
  Hits         3134     3134           
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/HelMel/genome_data.py 100.00% <ø> (ø)
stdpopsim/catalog/HelMel/species.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d5e2d...8cd25c3. Read the comment docs.

generation_time=1 / 10,
population_size=2.1e6,
generation_time=35 / 365, # 35 days
population_size=2111109,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
population_size=2111109,
# population size from the first of two datasets in Pardo-Diaz et al 2012
population_size=2111109,

Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly with that suggested change (if you think it's useful?), this is ready to go! Just needs a squash & rebase (assuming that fixes the CI errors).

@izabelcavassim
Copy link
Member

LGTM! :)

@petrelharp petrelharp merged commit 0f2c9fa into popsim-consortium:main Feb 16, 2022
@petrelharp
Copy link
Contributor

Yay! Thanks, @noscode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants