-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QC for HelMel species #1165
QC for HelMel species #1165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 95 95
Lines 3148 3148
Branches 413 413
=======================================
Hits 3134 3134
Misses 6 6
Partials 8 8
Continue to review full report at Codecov.
|
generation_time=1 / 10, | ||
population_size=2.1e6, | ||
generation_time=35 / 365, # 35 days | ||
population_size=2111109, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
population_size=2111109, | |
# population size from the first of two datasets in Pardo-Diaz et al 2012 | |
population_size=2111109, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly with that suggested change (if you think it's useful?), this is ready to go! Just needs a squash & rebase (assuming that fixes the CI errors).
LGTM! :) |
Yay! Thanks, @noscode! |
It includes updated chromosome lengths and generation time.
For more information see Issue #880.