Remove Circle CI. #1270
Remove Circle CI. #1270
Conversation
This moves codecov reporting into github actions. Closes popsim-consortium#779. Closes popsim-consortium#1222.
|
I've disabled the circle CI webhook in the github settings panel, but I didn't delete the webhook. I also didn't delete the deploy key. So we can easily reenable circle if we have to. Codecov for this PR was evidently uploaded successfully (https://codecov.io/gh/popsim-consortium/stdpopsim/commit/19713134fd5b1deeef7807414a675bab3ec3144c/), so I'm not sure why codecov didn't comment here with a coverage report as usual. |
|
Hm - we do want the codecov comments; perhaps it won't comment until it's merged in to |
|
Yes, I think that it will work once this is merged. We're now reporting coverage info for 6 OS/PYTHON combinations (as opposed to one before), so probably there wont be any base commit against which this new info can be compared - until this is merged. |
|
Well, looks good to me - go ahead and merge? |
This moves codecov reporting into github actions.
Closes #779.
Closes #1222.