flat (0) maps for non-existing chrom maps #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
+ Coverage 94.32% 96.92% +2.6%
=========================================
Files 8 8
Lines 282 293 +11
Branches 14 16 +2
=========================================
+ Hits 266 284 +18
+ Misses 13 5 -8
- Partials 3 4 +1
Continue to review full report at Codecov.
|
jgallowa07
force-pushed
the
define_recombination_map_behavior
branch
2 times, most recently
from
6f2cd92
to
1ec4b98
Compare
jeromekelleher
requested changes
Mar 13, 2019
There was a problem hiding this comment.
This is a good start @jgallowa07, but we need to be a lot more careful about the corner cases. See the comments above (sorry, I should have made them part of the review).
petrelharp
reviewed
Mar 13, 2019
There was a problem hiding this comment.
Looking good, thanks @jgallowa07. A few more minor changes and I think we're there.
jgallowa07
force-pushed
the
define_recombination_map_behavior
branch
from
375acea
to
ae0e4ad
Compare
jeromekelleher
approved these changes
Mar 14, 2019
|
@petrelharp @andrewkern does this look good to you? |
|
looks good @jgallowa07! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for defining a recombination map across all chromosomes on a species genome.