New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template for requesting addition of a new species #772
template for requesting addition of a new species #772
Conversation
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 34 34
Lines 2413 2413
Branches 298 298
=======================================
Hits 2404 2404
Misses 4 4
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe we don't need the chromosome list though?
|
||
**Chromosome structure:** | ||
|
||
- [] list of chromosomes with *name* and *length* (in bp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are coming from ensembl now, so this isn't strictly necessary, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking of which, the Ensembl ID is a necessary bit of info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should give more info on how to get the Ensembl ID, etc.
|
||
**Chromosome structure:** | ||
|
||
- [] list of chromosomes with *name* and *length* (in bp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking of which, the Ensembl ID is a necessary bit of info.
|
||
**Recombination rates:** | ||
|
||
- [] genetic map (as a .csv) of recombination rates **(optional)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or Hapmap? Don't want to people to convert to CSV if it's already in the right format.
Hm. So, here's the species that are apparently available on ensembl: I think that's all? I can't find a list of ensembl sites. And, what do we do about species not in Ensembl (e.g., there are no Mimulus, looks like)? Do we say that we're only for species with annotations uploaded to Ensembl? Any idea how difficult getting a new species on there is? |
I guess we could put the data files in by hand for species that aren't in Ensembl. We'd have to introduce some level of QC then, though.
No - can't imagine it's a quick process though, by the time the data gets into a release. |
Can we do this currently or would this require a lot of changes to the infrastructure? In other words, is this something we want to allow in the "adding to the zoo" workshop? |
9505453
to
8026455
Compare
Ok, I've updated this - I think it's OK now, unless we think we will never want to support non-Ensembl species. |
No, probably not. I think we should focus on Ensembl species for the workshop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This would be a way for someone to compile the relevant information for adding a new species without doing the coding.