-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Streptococcus agalactiae CC17 strains. #854
Conversation
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 99.39% 99.50% +0.10%
==========================================
Files 68 58 -10
Lines 2474 2407 -67
Branches 285 285
==========================================
- Hits 2459 2395 -64
+ Misses 7 5 -2
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
Sorry, this the wrong button! |
Looks great to me @jeanrjc! A couple of minor things:
thanks for the contribution! |
ah damned, it's an old email address that was hanging around in an old global .gitconfig. Do you know if I can change it in the commit ? Maybe while rebasing ? |
You can change it with commit --amend I think, or by "edit"ing during the rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Follow up PR for issue #843.
I discussed in the corresponding issue how I came up with the parametrization.