Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streptococcus agalactiae CC17 strains. #854

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

jeanrjc
Copy link
Contributor

@jeanrjc jeanrjc commented Apr 8, 2021

Follow up PR for issue #843.

I discussed in the corresponding issue how I came up with the parametrization.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #854 (8033d33) into main (e6e1c15) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 8033d33 differs from pull request most recent head aaaaf45. Consider uploading reports for the commit aaaaf45 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   99.39%   99.50%   +0.10%     
==========================================
  Files          68       58      -10     
  Lines        2474     2407      -67     
  Branches      285      285              
==========================================
- Hits         2459     2395      -64     
+ Misses          7        5       -2     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
stdpopsim/catalog/StrAga/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/StrAga/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/StrAga/species.py 100.00% <100.00%> (ø)
stdpopsim/engines.py 100.00% <0.00%> (ø)
stdpopsim/genetic_maps.py 100.00% <0.00%> (ø)
stdpopsim/catalog/BosTau/species.py 100.00% <0.00%> (ø)
stdpopsim/catalog/DroMel/species.py 100.00% <0.00%> (ø)
stdpopsim/catalog/BosTau/demographic_models.py 100.00% <0.00%> (ø)
stdpopsim/catalog/HelMel/genome_data.py
stdpopsim/catalog/HelMel/species.py
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e1c15...aaaaf45. Read the comment docs.

@jeromekelleher
Copy link
Member

Sorry, this the wrong button!

@jeromekelleher
Copy link
Member

Looks great to me @jeanrjc! A couple of minor things:

thanks for the contribution!

@jeanrjc
Copy link
Contributor Author

jeanrjc commented Apr 8, 2021

Looks like your github email isn't in sync (so you won't get contributations attributed to you correctly). See here for more info

ah damned, it's an old email address that was hanging around in an old global .gitconfig. Do you know if I can change it in the commit ? Maybe while rebasing ?

@jeromekelleher
Copy link
Member

ah damned, it's an old email address that was hanging around in an old global .gitconfig. Do you know if I can change it in the commit ? Maybe while rebasing ?

You can change it with commit --amend I think, or by "edit"ing during the rebase.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeromekelleher jeromekelleher merged commit fdfa6d6 into popsim-consortium:main Apr 9, 2021
@petrelharp petrelharp mentioned this pull request May 16, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants