-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genotype job tests #419
base: main
Are you sure you want to change the base?
Conversation
- Handle exomes - More details for postproc gvcf jobs - Add code for a failing test, worth discussion
* Split test cases to avoid if-else statements and improve readability * Test some additional cases, like exome/genome. * Use select_jobs to avoid iterating through all the jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an analysis perspective, this looks good to me. The only thing I can't really comment on is the GQ band thresholding, and why these intervals are chosen (@silkm not sure if you know more about this?). Otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Software side it looks good to me!
This PR adds the genotype job tests as described https://miro.com/app/board/uXjVPPN9TaM=/
Not every use case was handled as expected, described below