Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up list workflows #698

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MattWellie
Copy link
Contributor

Closes #688 (If this is not required, #688 should also be rejected as won't do. Feel free to, I promise I won't cry)

Changes the order of main.py argument processing:

  • if list_workflows:

    • List workflows (and end points), then quit
  • list_workflows doesn't require the workflow param to be set, but it should be set for all other purposes, so after this return, assert a valid workflow is named

  • if list_last_stages:

    • list last stages for the current workflow (this feels redundant with list_workflows already providing this information), then quit
  • For all other uses, assert that a valid workflow is defined, and continue as usual

This is a super low priority change, I don't think either of these flags are used by anybody, but maintaining a special case of --workflow list is odd.

@MattWellie MattWellie requested a review from vivbak April 18, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrangle list-workflows CLI arguments
1 participant