TASK: Robust Metamist Integrations #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, but could we do it in a separate PR (merged before this one). If something goes wrong it's easier to track down the cause! |
…t API and implement timeout tests.
vivbak
reviewed
Jun 24, 2024
|
|
||
| from cpg_utils import to_path | ||
| from metamist.apis import AnalysisApi |
There was a problem hiding this comment.
Nice! Gross that we used to do this here.
vivbak
reviewed
Jun 25, 2024
| from metamist.exceptions import ApiException | ||
| from metamist.models import Analysis, AnalysisStatus | ||
|
|
||
| from .metamist import AnalysisStatus, get_metamist |
There was a problem hiding this comment.
We just need to keep an eye on this it case it creates any pickling issues. Let's try a test run later!
ckrishk
reviewed
Jul 11, 2024
| logging.error( | ||
| f'Error: {e} Call {api_func} failed with payload:\n{str(kwargv)}', | ||
| ) | ||
| # TODO: discuss should we catch all here as well? |
ckrishk
reviewed
Jul 11, 2024
| return True | ||
|
|
||
|
|
||
| def mock_aapi_update_analysis_timeout_fails(*args, **kwargs): |
ckrishk
reviewed
Jul 11, 2024
| @retry( | ||
| stop=stop_after_attempt(3), | ||
| wait=wait_exponential(multiplier=3, min=8, max=30), | ||
| retry=retry_if_exception_type(ServiceException), |
There was a problem hiding this comment.
is there a way for us to be alerted if too many of these exceptions are raised?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing items for task Robust Metamist Integrations on the road map.
TODO
WIP, this PR latest coverage at 76%
Two functions in metamist are with comments 'not used anywhere' (process_existing_analysis, find_joint_calling_analysis), Should we remove? It would make test coverage at 91% after this PR.It seems we just need to differentiate between ServiceException and the rest of ApiException.
ServiceException can be retried or other we should stop.
Metamist timeouts killing pipelines #585
Error Details: It fails on
Exception:
production-pipelines/cpg_workflows/metamist.py
Line 318 in f4801c6
Solution: We are ging to keep the existing behaviour
production-pipelines/cpg_workflows/metamist.py
Line 635 in f4801c6