Skip to content

Commit

Permalink
use newest nan
Browse files Browse the repository at this point in the history
  • Loading branch information
@porsager
porsager committed Sep 30, 2014
1 parent 67bf823 commit 6532306
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"main": "./index.js",
"engines": {
"node": ">=0.8.0"
"node": ">=1.2.0"
},
"license": "MIT/X11",
"dependencies": {
Expand Down

4 comments on commit 6532306

@natevw
Copy link

@natevw natevw commented on 6532306 Oct 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be why I'm running into electron/electron#671 — you've accidentally updated the node engine version instead of nan. If I get a chance later today I can send a PR but leaving this here in case I don't.

@porsager
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right ! I noticed i forgot to update nan, and then made a little hasty commit :) I've just made another that fixes it. Thanks for letting me know ! Does it work for you after this fix ?

@natevw
Copy link

@natevw natevw commented on 6532306 Oct 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Thanks so much — now I can choose between latest node-webkit or atom-shell, instead of stuck on old nw 👍

@porsager
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nate.
I've just been messing around with my fork, and i think there's a lot of things not working. I tried out the one below instead which seems to work, so i'd recommend that you use that instead ;)
https://github.com/Elzair/node-hid

Please sign in to comment.