-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 8079 update GitHub actions for aws #1212
Port 8079 update GitHub actions for aws #1212
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
...ate-self-service-experiences/setup-backend/github-workflow/examples/AWS/push-image-to-ecr.md
Show resolved
Hide resolved
} | ||
"repository": "{{ .inputs.\"repository\" }}", | ||
"tags": "{{ .inputs.\"tags\" }}", | ||
"context": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename it to port_context
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant for the other files in the PR as well
@@ -238,11 +212,10 @@ on: | |||
type: string | |||
required: true | |||
description: 'Tags should be in key-value pairs like so: {"key": "value"}' | |||
port_payload: | |||
context: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to rename here too :)
"ec2_name": "{{ .inputs.\"ec2_name\" }}", | ||
"ec2_instance_type": "{{ .inputs.\"ec2_instance_type\" }}", | ||
"pem_key_name": "{{ .inputs.\"pem_key_name\" }}", | ||
"context": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"context": { | |
"port_context": { |
@@ -288,7 +288,7 @@ on: | |||
description: EC2 pem key | |||
required: true | |||
type: string | |||
port_payload: | |||
context: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context: | |
port_context: |
"properties": {}, | ||
"censoredProperties": "{{.action.encryptedProperties}}" | ||
} | ||
"context": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"context": { | |
"port_context": { |
} | ||
"dockerfile": "{{ .inputs.\"dockerfile\" }}", | ||
"image_repo": "{{ .inputs.\"image_repo\" }}", | ||
"context": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"context": { | |
"port_context": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go over @pazhersh comments
Description
Update the AWS GitHub guides with the v2 actions schema
Updated docs pages
Please also include the path for the updated docs