Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container details should show image name as well #1369

Closed
alexanderadam opened this issue Nov 8, 2017 · 5 comments
Closed

Container details should show image name as well #1369

alexanderadam opened this issue Nov 8, 2017 · 5 comments
Assignees
Milestone

Comments

@alexanderadam
Copy link

It is possible to see the image name if you click on "Duplicate/Edit" again but it is not visible on the regular detail view yet.

@eine
Copy link
Contributor

eine commented Nov 8, 2017

The image ID is shown in the 'Container details' section of the container details view. The ID points to the details of the image where the tags are shown. You mean to show those tags next to the image ID?

@alexanderadam
Copy link
Author

alexanderadam commented Nov 8, 2017

I didn't wrote the .image id. I meant the image name from the registry. Like ruby:latest or similar.

Yes, exactly.

@deviantony
Copy link
Member

I believe we can replace the ID with the name of the image (extracted from Config.Image).

@eine
Copy link
Contributor

eine commented Nov 9, 2017

@deviantony, related to #1370, is Config.Image valid when the tag is updated? Example:

  • Tag image with ID id_a as mytag.
  • Run container mycontainer based on mytag.
  • Create image with ID id_b and tag it as mytag.

Now Config.Image points to mytag, which refers to id_b. But it is not true that the container is based on that image.


Actually, the image ID is now read from .Image, which is correct even if tags are updated after the container was created.

Therefore I think that instead of extracting Config.Image, we should get the tags of the image ID (if they exists).

@alexanderadam
Copy link
Author

I also think that the ID still makes sense. So I wouldn't want it to be replaced and I rather want to have the name shown additionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants