Git Pull on Stack Deploy fails with valid URL

[turbo]

Bug description

VSTS Git URLs look like this:

https://user:password@example.visualstudio.com/TeamName/_git/repo

where repo is the name of the repository. The bug is that portainer fails to pull a valid repo with the following error message:

Deployment error
unexpected client error: unexpected requesting "https://turbo:***@***.visualstudio.com/***Cloud/_git/azure/git-upload-pack" status code: 400

Expected behavior

The same as git clone, which doesn't fail:

$ git clone https://turbo:***@***.visualstudio.com/***Cloud/_git/azure
Cloning into 'azure'...

Clones the repo just fine.

Technical details:

• Portainer version: 1.17.1
• Docker version (managed by Portainer): 18.03ce
• Platform (windows/linux): linux
• Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): stack
• Browser: Chrome

[turbo]

Portainer send an invalid git request to the server (it appends git-upload-pack the the URL). This causes a GitProtocolException, with the following error message:

TF401041: The Git protocol sent is not as expected (Unable to read the 4-byte length header of the message.).

[turbo]

This is likely a pretty major bug (missing multi_ack support) in go-git that has been unfixed for quite a while: src-d/go-git#335 (comment)

This is a real deal-breaker for us.

[turbo]

Out of curiosity, are bug fixed prioritized for businesses with a support subscription?

[ncresswell]

Yes indeed. For businesses with a support subscription, there is a SLA for big fixes. Rgds, Neil Cresswell On 25/05/2018, at 8:18 PM, turbo <notifications@github.com<mailto:notifications@github.com>> wrote: Out of curiosity, are bug fixed prioritized for businesses with a support subscription? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1926-23issuecomment-2D391978566&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=pULOtN9BDE3N1F34nnD5un-JoAktLjGMVTQQR19OCXQ&s=JCIGqwaON-yHBXMt9LRKIo8YvBk-d116MOEI0UI1nOc&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlTQSBzWICIhONgm6w4QT2q3l59qiks5t175OgaJpZM4UJ7nX&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=pULOtN9BDE3N1F34nnD5un-JoAktLjGMVTQQR19OCXQ&s=p0Z4XUED6gmbyUjM0oZ5jIKF3Mme06dHOFYGumXzUKc&e=>.

[olljanat]

@turbo FYI I have implemented alternative method for VSTS users: https://marketplace.visualstudio.com/items?itemName=OlliJanatuinen.portainer-deploy

[turbo]

@olljanat I saw that, but we don't use any Windows agents. Since there is a discussion about pulling from git in #1752, I'd prefer a first-party solution.

[GrumpyMeow]

I work for a Microsoft oriented company which is trying to adopt Docker.
For us the ability to clone from VSTS would make the adoption much user friendlier.
In this thread someone described that the issue is already resolved in Go-Git a while ago.
Is resolving this issue not as easy as using a later version of Go-Git?

[deviantony]

Hi @GrumpyMeow

Based on #1926 (comment)

This is likely a pretty major bug (missing multi_ack support) in go-git that has been unfixed for quite a while: src-d/go-git#335 (comment)

It has not been resolved, unfortunately no activity on go-git for this one. One solution here would be to use another library than go-git as our git service implementation.

[olljanat]

@turbo / @GrumpyMeow It is nice to see that more VSTS users are joining to Portainer users. But in same time it feels that you are are thinking this bit weird way.

On fully adopted implementation VSTS is much more than just Git repository, it also owns whole CI/CD pipeline(s), test automation, all approval chains, work item management, etc.

That why IMO VSTS must push services to Portainer rather than Portainer would pull them.

But I created another feature request about it to #2448 so please share your though about it on there.

[turbo]

@olljanat We're using VSTS as a code hosting platform, not as a build platform. Our issue is exactly what I described here and not more.

This is a bug in the git pull done by Portainer, it doesn't really matter what service is on the other end. We are paying Portainer customers and would like to see this resolved. VSTS (now called Azure DevOps btw.) integration beyond that might be relevant to other users, but not to us.

[olljanat]

@turbo OK. I understand that this one is bug from users point of view but from code point of view issue is that any of authentication methods which are supported by VSTS have not been implemented to libraries which Portainer currently uses so it is bit more tricky to fix than normal bug fixes.

But as VSTS also supports connecting Git repos with SSH , I understood from your comment that options works for you I think that best options would be then finalize PR #2294 and add comment to documentation that with VSTS you need use SSH authentication.

Works for you?

[turbo]

Yes, SSH would be the preferred way to connect to Azure DevOps for us.

[filipvaleriu]

I have found that calling
git commit -m "Init"
and afterwards
git push -u origin --all
works ok

[olljanat]

@filipvaleriu sorry but I did not understood that how that is related to this issue which talks about git pull issue (not push)?

[filipvaleriu]

Yes, i see now, you are corect about that.
Still i ended up on this forum post, after i was stuck in that same error message for not beeing able to make an initial push for my newly created local git repository; after reading the post and finding also somewhere else some clues, not seeing anymore that was about pull instead of push, i thought might be helpfull for others to see a solution.

[GrumpyMeow]

@olljanat We're trying to go all-in on VSTS: build agents, CI/CD, Pull Requests, GIT, scrumb board, etc.
I want to give all developers from my department the option to run Portainer locally on their development machines to manage Docker in a more user-friendly manner.
For now i don't feel comfortable to start using webhooks.

[olljanat]

@GrumpyMeow OK. Would #1752 work for your use cases?

We have about 90% ready solution for it on #2294 which just would need to be finalized.

Then what comes to CI/CD into real production envs please comment about it to #2448

[ghost]

This issue has been marked as stale as it has not had recent activity, it will be closed if no further activity occurs in the next 7 days. If you are able to reproduce this issue on the latest version of Portainer, feel free to leave a comment and we can pick up this issue again.

[ghost]

Since no further activity has appeared on this issue I will close it for now. If you are able to reproduce this issue on the latest version of Portainer, feel free to leave a comment and we can pick up this issue again.

[mateuszdrab]

@deviantony Hey Tony. Sorry to dig this out from the dead. I've been affected by the impossibility to deploy a stack from VSTS as well. Considering that the underlying issue in is still not resolved in the go-git package and it's been 3 years since that issue was created. Wouldn't it be possible to use the git executable instead?

[deviantony]

@mateuszdrab yeah that could be an approach, I'm always reluctant to use binaries against libraries for the following main reasons:

• Multi-platform setup requirements
• Error/standard output handling of a binary

That underlying issue in the go-git library seems to be a major one, as such I would not see any problem switching to the usage of the binary (it's just about implementing the GitService interface inside the exec package).

If we start relaying on more git features in Portainer, I can see this as a direction where we would want to go. In the meantime, any contribution to the discussion/implementation of using the git binary is welcome.

cc @ncresswell

NOTE: interesting link on the source of golang which is actually doing this behind the scenes here

[deviantony]

Also re-opening this issue.

[ghost]

Since the opening of this issue, VSTS became Azure DevOps. So to test this I went and set up an Azure repo and tried to deploy a stack from it, but I keep getting Deployment error {"message":"Unable to clone git repository","details":"authentication required"}.
@mateuszdrab is this the error you are receiving or am I doing something wrong?

Additional Info:

• I created git credentials including a PAT using the Azure repo GUI and have entered this in Portainer.
• My HTTPS clone url is https://****@dev.azure.com/****/Portainer-testing/_git/Portainer-testing where **** is the name of my Azure organization.
• Cloning with the same url and credentials from the CLI works fine.

[ghost]

@deviantony have you reproduced?

[deviantony]

I did not reproduce as I do not have any VSTS related environment. Re-opening for the binary usage consideration.

[mateuszdrab]

@itsconquest I think you neeed to take out the credentials from the URL and put it in the authentication section within portainer. Then you should see error 400 - the issue I'm experiencing also. When using the PAT, you can put anything for the username, and the PAT for the password.

[ghost]

Ah yes it seems that I can indeed reproduce this including the appending of /git-upload-pack to the url in 1.23.2. Thanks for the tip!

[deviantony]

Closed via #5070