Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configs for Swarm mode services #988

Closed
thojkooi opened this issue Jul 6, 2017 · 7 comments
Closed

Support configs for Swarm mode services #988

thojkooi opened this issue Jul 6, 2017 · 7 comments
Milestone

Comments

@thojkooi
Copy link
Contributor

thojkooi commented Jul 6, 2017

In Docker 17.06.0 the concept of configs are introduced:

Add support for services to carry arbitrary config objects moby/moby#32336, docker/cli#45, moby/moby#33169

https://github.com/docker/docker-ce/releases/tag/v17.06.0-ce


  • Config endpoints are available in the Docker remote API under /configs.
  • The implementation and interface is similar to secrets.
    • This would cover the ability to create, inspect and remove a config. Updating does not seem to be supported by the API.
    • and be able to assign a config to a service, and remove it. Just like the Service Secrets.

Documentation:

I'm happy to do the work on the initial implementation.

@deviantony
Copy link
Member

I'd be happy to receive a PR from you :-)

thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 7, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 7, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 7, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 9, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 9, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Jul 10, 2017
@artheus
Copy link

artheus commented Aug 18, 2017

@Glowbal @deviantony What is this issue exactly? As far as I can see, config has been implemented and released in stable
This issue confused me into thinking that docker configs, for now, only works in docker on single hosts (not in Swarm mode). But it seems to work very good in swarm mode.

@deviantony
Copy link
Member

@artheus as @Glowbal specified in the issue description, this is to add Docker config (https://docs.docker.com/engine/reference/commandline/config/) support inside Portainer.

I think that Docker configs can only be used within Swarm services (like the secrets). What config are you talking about ? What stable version are you talking about?

@thojkooi
Copy link
Contributor Author

This issue is indeed about the config support in Swarm mode, which is available since Docker 17.06. Docker configs indeed only work in Swarm mode.

@zhaoyao91
Copy link

So what's the status of this issue? Will portainer support swarm config introduced by Docker 17.06?

@deviantony
Copy link
Member

@zhaoyao91 there is a work in progress on this, follow #996

thojkooi added a commit to thojkooi/portainer that referenced this issue Sep 13, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Oct 7, 2017
@nicolasgere
Copy link

@thojkooi if you need help, i want this feature :-)

thojkooi added a commit to thojkooi/portainer that referenced this issue Oct 28, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Nov 1, 2017
thojkooi added a commit to thojkooi/portainer that referenced this issue Nov 1, 2017
…n the api

WIP for expanding portainer#996 with proper access control in the API
@deviantony deviantony added this to the 1.15.x milestone Nov 6, 2017
@deviantony deviantony modified the milestones: 1.15.x, 1.15.1 Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants