Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configs #45

Merged
merged 2 commits into from
May 12, 2017
Merged

Add support for configs #45

merged 2 commits into from
May 12, 2017

Conversation

aaronlehmann
Copy link
Contributor

This adds CLI support for the configs feature (moby/moby#32336).

It should not be merged until the moby PR is merged.

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 😉

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@aaronlehmann aaronlehmann changed the title [WIP] Add support for configs Add support for configs May 11, 2017
@aaronlehmann
Copy link
Contributor Author

Rebased. Please merge to unblock other moby PRs that involve CLI (this fork is currently referenced).

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 05267be into docker:master May 12, 2017
@thaJeztah thaJeztah added this to the 17.06.0 milestone May 15, 2017
albers added a commit to albers/docker-cli that referenced this pull request Jul 3, 2017
This adds bash completion for
- docker#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
albers added a commit to albers/docker-cli that referenced this pull request Jul 7, 2017
This adds bash completion for
- docker#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
thaJeztah pushed a commit to thaJeztah/docker-ce that referenced this pull request Jul 25, 2017
This adds bash completion for
- docker/cli#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
alshabib pushed a commit to alshabib/cli that referenced this pull request Aug 1, 2017
This adds bash completion for
- docker#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
riyazdf pushed a commit to riyazdf/cli that referenced this pull request Aug 2, 2017
This adds bash completion for
- docker#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 29, 2020
This adds bash completion for
- docker/cli#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
silvin-lubecki pushed a commit to silvin-lubecki/cli-extract that referenced this pull request Jan 30, 2020
This adds bash completion for
- docker/cli#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c40952b)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants