-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stacks): support compose v2.0 stack #1963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: api/http/handler/endpoint.go app/portainer/__module.js app/portainer/services/fileUpload.js
Conflicts: api/http/handler/user.go
Conflicts: api/http/handler/endpoint.go
Conflicts: app/docker/views/stacks/edit/stack.html app/portainer/views/stacks/stacks.html
deviantony
added
the
breaking-changes
This pull request introduces breaking changes
label
Jun 11, 2018
This was referenced Jun 11, 2018
This was referenced Jun 11, 2018
xAt0mZ
pushed a commit
that referenced
this pull request
Aug 25, 2022
…1963) * fix(registry): fixed the unauthorized error caused by settings api [EE-3660] * remove unused line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings adds the ability to manage compose v2 stacks inside Portainer when connected to a standalone Docker environment.
It uses libcompose behind the scene to manage the stacks. Due to some limitations in the official libcompose library, it's currently using this fork: https://github.com/portainer/libcompose
Another limitation is that this library only support compose version 2 (do not support >= 2.1). We'll try to contribute to the official libcompose project to fix these limitations.
Close #257 (woohoo 🎉)
Also adds the ability to manage external stacks, closing #1351
Brings enhancements to the overall stack/service management UX:
view logs
link for tasks that can't possibly have logs. #1875Introduces breaking changes to the API by relocating
/endpoints/<id>/stacks
to/api/stacks
, the Swagger documentation has been updated. Closes #1847A refactor of the
handler
package brings more clarity to the package as well as enhancements regarding status code returned by the API, closing #1811 as well.