feat(endpoint): make the endpoint struct smaller when serialized [EE-4754] #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat83
reviewed
Feb 9, 2023
hookenz
force-pushed
the
feat/EE-4754/omit-empty
branch
from
802e4e6
to
d33b69e
Compare
prabhat83
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liberal addition of omitempty. This has reduced the size of the serialized endpoint object by at least 2/3 or more. It also strips data not relevant for some endpoint types. End result - faster maybe marshaling and unmarshaling and slightly less data on the wire.
I've also changed some embedded object types to pointers. specifically Kubernetes endpoint types.
See: EE-4754