-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected tone_key.cpp Motorola Code #850
Corrected tone_key.cpp Motorola Code #850
Conversation
Corrected Motorola Code on a few freqs.
Do they have to follow Motorola's rule ? |
They don't, I just noticed when testing that the codes had some typos, so I corrected them. |
Hi @KillerTurtleSoftware , I appreciate your typo error correction PR . Your PR seems OK . It is strange, not pointed before. |
This is being used in the Receive---Audio app. At least that is the app I saw the issue. I did last night, while working on a new app. |
Hi @KillerTurtleSoftware Anyway you mean , in the automatic CTCSS tone detection in the NFM mode , Audio App ? |
The options_tone_key when in NFM is where it is set. It's only visible if you are in NFM mode. Correct Audio App. I haven't gotten a chance to check the receive, as I have the RF system analyzer at my work. I will do the check either Monday at work, or I may grab one of our older Spectrum analyzers and bring it home this weekend to check. |
Hi @KillerTurtleSoftware thanks a lot for your answer |
The Mic App tx can select the Tone Key, if Mode is set to "NFM/FM". The option that had the issue was "16 2Z", I corrected it to "16 2A". So this should be able to be selected and your other Portapack, should be able to decode it to the matching code. When I was testing it before, it was showing the correct line number of the CTCSS freq, so it's decoding them correctly. FYI, This is my first time doing anything on Github, so I apologize if I should have submitted this different. |
Hello , @KillerTurtleSoftware , now I finally could understand you! The freq. is correct , it is just the character name mistake . I agree ! Based on Wikipedia , you are completely correct . |
That's correct just the OSD name was wrong. I went thru and checked the frequencies on all of them, to make sure there weren't any other mistakes, and that's when I found 11 and 12 were wrong as well. |
Hi again , @KillerTurtleSoftware , I checked several random CTCSS freq. and all of them matches with the labelled freq. Just plotting one example, , |
Corrected Motorola Code on a few freqs.