Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support simultaneous multi-instance (feature request) #6

Closed
GnstheGrain opened this issue Sep 26, 2017 · 3 comments
Closed

Support simultaneous multi-instance (feature request) #6

GnstheGrain opened this issue Sep 26, 2017 · 3 comments
Assignees

Comments

@GnstheGrain
Copy link

GnstheGrain commented Sep 26, 2017

Feature description/purpose:
Support running multiple instances simultaneously, allowing user to use as many Discord Account/IDs at once.

Steps to reproduce this issue unimplemented feature

  1. Launch discord-portable.exe
  2. Launch discord-portable.exe (2nd instance)
  3. Launch discord-portable.exe (3rd instance)
  4. [...]

Actual behaviour

Launching each of those redirect to (reopen) the current running instance.

Expected behaviour

  • Each launched instance should execute as a single separate "discord-portable.exe" process
    (Many portable tools offers such multi-instance feature by implementing an optional switch for the user to launch from. ie. $ discord-portable.exe {-p|m}
  • Each instance should not only be allowed to run seperately, but let the user to log into distinct Discord ID/Accounts as well.)
  • (Optional, but preferable) Each instance should be contained/isolated (if required) , in order to prevent both of any Account/Machine-lvl -UUID correlation from being performed/detect from Discord's servers. (if any such thing appears to be existing in the code).. for instance: I've notice the Preferences file to use the (now depreciated) brightray library, (which I assume stem from the Electron repacking/wrapping process): {"brightray":{"media":{"device_id_salt":"<SALTHASH>"}}}
    (However, I know close to nothing about Electrum, so this brightray code could very well be only used by Electrum to properly bound the repacked app with the target machine, hence, not necessarily used/fetched in any way by/to discord's servers.) This however remains unverified.. it would require some research and/or audit to confirm. (some basic-yet-rigorous traffic analysis would make it).

Discord portable version :
v0.0.298-13

@crazy-max
Copy link
Member

@GnstheGrain I will take a look on this feature, i keep you in touch.

@crazy-max crazy-max self-assigned this Oct 26, 2017
@crazy-max
Copy link
Member

Hi @GnstheGrain, i've worked on this feature and it will be available in the next release ;)

crazy-max added a commit that referenced this issue Jan 13, 2018
No need to override USERPROFILE environment variable anymore
Allow multiple instances (Issue #6)
@crazy-max
Copy link
Member

Implemented in latest release : https://github.com/portapps/discord-portable/releases/tag/0.0.300-19
For your last point about machine id, open a new issue please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants