Previews of tokens #20

[luckyrobot]

closes #20

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/porter-finance/frontend-ido/FmRjjf1vgT2WX44nM8QFVqqg85Yb
✅ Preview: https://frontend-ido-git-previews-of-tokens-20-porter-finance.vercel.app

[RusseII]

Vercel preview looks great! Feel free to merge or address comment

[RusseII]

Thoughts and removing this from the bond file and encapsulating the state in the hook itself? Then doing the format wherever the value is being displayed?

So instead of:

const previewConvert = useCallback(
    async (amountToPreview?: TokenAmount | null): Promise<string> => {
      if (!tokenContract) {
        logger.error('tokenContract is null')
        return ''
      }

      if (!amountToPreview) {
        logger.error('missing amount to preview')
        return ''
      }

      const response = await tokenContract
        .previewConvertBeforeMaturity(amountToPreview.raw.toString())
        .catch((error: Error) => {
          logger.debug('Failed to preview token', error)
          throw error
        })

      return response
    },
    [tokenContract],
  )

Something like

  const usePreviewConvert = async (amountToPreview?: TokenAmount | null, bondAddress: string): Promise<string> => {
    const tokenContract = useBondContract(bondAddress)

    const [amount, setAmount] = useState(null)
    if (!tokenContract) {
      logger.error('tokenContract is null')
    }
    useEffect(() => {
      const previewConvert = async () => {
        const number = await tokenContract
          .previewConvertBeforeMaturity(amountToPreview.raw.toString())
          .catch((error: Error) => {
            logger.debug('Failed to preview token', error)
            throw error
          })
        setAmount(number)

      }

      previewConvert()
    }, [amountToPreview, tokenContract])

    return amount 

  )
}

We could also leave cleanup tasks like this to later if you think that makes sense

[RusseII]

Might not be worth changing now if we start using that multicall thing namaskar mentioned

[RusseII]

https://github.com/joshstevens19/ethereum-multicall

[luckyrobot]

yeah will check this again after multicall

[luckyrobot]

good idea