Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to create a bond from the UI (product creation page) #32 #26

Merged
merged 31 commits into from
Mar 29, 2022
Merged

Add ability to create a bond from the UI (product creation page) #32 #26

merged 31 commits into from
Mar 29, 2022

Conversation

luckyrobot
Copy link

closes #

@vercel
Copy link

vercel bot commented Mar 25, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/porter-finance/frontend-ido/7VKRPx8w2wWb7zfQ5VtZjU1ckskG
✅ Preview: https://frontend-ido-git-add-ability-to-create-a-836049-porter-finance.vercel.app

@luckyrobot luckyrobot changed the base branch from main to previews-of-tokens-#20 March 25, 2022 20:52
@luckyrobot luckyrobot changed the base branch from previews-of-tokens-#20 to main March 29, 2022 00:04
RusseII
RusseII reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@RusseII RusseII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments so far - will review more tomorrow

@luckyrobot luckyrobot mentioned this pull request Mar 29, 2022
Closed
27 get price data for collateral token (#28)
9d7f6d2 
* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>
@RusseII
Copy link
Contributor

RusseII commented Mar 29, 2022

Wow all conflicts fixed!

@luckyrobot luckyrobot requested a review from RusseII March 29, 2022 02:54
RusseII
RusseII approved these changes Mar 29, 2022
View reviewed changes
src/hooks/useApproveCallback.ts Outdated
@@ -1,6 +1,7 @@
import { useCallback, useMemo } from 'react'

import { MaxUint256 } from '@ethersproject/constants'
import { Contract } from '@ethersproject/contracts'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable? Why didn't the pre-commit hooks catch this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its a "warning" not an "error" so it allows it to go through

but im using intellij now and it will auto optimize imports when i hit save. super lux

@luckyrobot luckyrobot merged commit ca07189 into main Mar 29, 2022
@luckyrobot luckyrobot deleted the Add-ability-to-create-a-bond-from-the-UI-(product-creation-page)-#32 branch April 20, 2022 12:49
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
eed0686 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
1bc09cb 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
7309d67 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy pushed a commit that referenced this pull request May 7, 2022
@luckyrobot
Add ability to create a bond from the UI (product creation page) #32 (#…
64508b5 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
42d92d7 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
c08da3a 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit f148e4d
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Geczy added a commit that referenced this pull request May 7, 2022
@Geczy
Add ability to create a bond from the UI (product creation page) #32 (#…
daf81e5 
…26)

* upgrade packages

* remove documentation pages

* fix max supply of convert

closes #21

* when logged out on bond page

closes #22

* fix showing bond balance

* add preview of tokens

closes #20

* add portfolio page

closes #5

* calling hasRole

* fix disconnect

* add createBond function

* submit form values to contract

* this should fix routes

* fix create bond call

* create bond as a hook

* fix passing in args

* add role loading

* add mint & approve

* approveAndMint call

* add fake bond data for quick creations

* holy changes to mint

* finish minting

* Squashed commit of the following:

commit 3e952cc
Author: luckyrobot <97241616+luckyrobot@users.noreply.github.com>
Date:   Sat Mar 26 11:01:01 2022 -0700

    Previews of tokens #20 (#24)

    * upgrade packages

    * remove documentation pages

    * fix max supply of convert

    closes #21

    * when logged out on bond page

    closes #22

    * fix showing bond balance

    * add preview of tokens

    closes #20

* remove ethers

* fix missing paid function

* make tokenAmount more clear

* make available overflow ellipsis

* 27 get price data for collateral token (#28)

* add useTokenPrice hook

* add working token price hook

* linting - why aren't hooks doing this @luckyrobot?

* remove apollo add useSwr

* use rpl contract if not on mainnet

* reload pricing data every 5 seconds

* linting - why aren't hooks doing this @luckyrobot?

* fix linting and update refresh interval

* remove unused code

Co-authored-by: bookland <bookland.porter.finance>

Co-authored-by: RusseII <bookland@porter.finance>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RusseII RusseII RusseII approved these changes

@Namaskar-1F64F Namaskar-1F64F Awaiting requested review from Namaskar-1F64F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckyrobot @RusseII