Add tests #1
Merged
Add tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
suggested changes
Feb 1, 2017
| @@ -0,0 +1,20 @@ | |||
| language: python | |||
| python: 2.7 | |||
There was a problem hiding this comment.
It should also work with Py3
tests/test_client.py
Outdated
| @@ -0,0 +1,151 @@ | |||
| import mock | |||
| import pytest | |||
| from portier.client import discover_keys, get_verified_email | |||
tests/test_client.py
Outdated
|
|
||
| assert mocked_requests.get.call_count == 2 | ||
| mocked_requests.get.assert_any_call( | ||
| "http://broker-url.tld//.well-known/openid-configuration") |
tests/test_client.py
Outdated
| ) | ||
| keys = discover_keys("http://broker-url.tld/", cache) | ||
|
|
||
| assert isinstance(keys, dict) |
There was a problem hiding this comment.
I think that part doesn't have to be in the with
tests/test_client.py
Outdated
|
|
||
| def test_discover_key_raises_a_value_error_if_keys_not_found(): | ||
| cache = mock.MagicMock() | ||
| cache.get.return_value = None |
There was a problem hiding this comment.
Declare an empty_cache once on top somewhere?
There was a problem hiding this comment.
You want me to create a class with a setup phase right?
tests/test_client.py
Outdated
| {"kid": "abc", | ||
| "e": "KHTPnNouCvwROWeIWQkJiw", | ||
| "n": "ZgKgqvEo_GZMamwy293IvA", | ||
| "alg": "RS256"}]}, |
There was a problem hiding this comment.
I have the feeling that tests could be a lot easier to read if those crazy values would be declared once on top (eg. warm_cache, TOKEN, etc...)
tests/test_client.py
Outdated
| } | ||
| result = get_verified_email("http://broker-url.tld/", | ||
| "eyJraWQiOiAiYWJjIn0.foo.bar", | ||
| "audience", "issuer", cache) |
Is it better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leplatrem r?