Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected unset when $from and $to have the same value #14

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Fix unexpected unset when $from and $to have the same value #14

merged 1 commit into from
Sep 26, 2019

Conversation

cristoforocervino
Copy link
Contributor

If you set a map with the same key, that will be unexpectedly unset.
For example:

$mappingStep = new MappingStep();
$mappingStep
    ->map('[name]', '[name]')
    ->map('[surname]', '[surname]')
    ->map('[cellphone]', '[telephone]');

With this mapping, name and surname will be unsettled and lost during workflow execution.
This is unexpected. I fixed that just adding a little check more.

@Baachi Baachi merged commit 2f07b4b into portphp:master Sep 26, 2019
@icedevelopment
Copy link
Contributor

@Baachi could you please make a new bugfix release containing this?
There has been no new release since 2018-05-11.

@Baachi
Copy link
Contributor

Baachi commented Mar 4, 2020

@icedevelopment A new tag has been created!

@icedevelopment
Copy link
Contributor

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants