Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of the Portworx helm chart #1

Closed
wants to merge 5 commits into from
Closed

Initial commit of the Portworx helm chart #1

wants to merge 5 commits into from

Conversation

hr1sh1kesh
Copy link
Contributor

@hr1sh1kesh hr1sh1kesh commented Jan 29, 2018 •
edited
Loading

What this PR does / why we need it:
Initial commit of the helm chart for deploying Portworx.

Which issue(s) this PR fixes (optional)
Closes #2

Special notes for your reviewer:

harsh-px
harsh-px requested changes Jan 29, 2018
View reviewed changes
Copy link
Collaborator

@harsh-px harsh-px left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the Portworx chart in a "px" sub-folder as we may host other charts in this repo in future.

Also create a issue in this repository that briefly describes purpose of this helm chart and reference that issue in the "Closes.." comment of this PR.

@hr1sh1kesh
Copy link
Contributor Author

@harsh-px i have addressed the review comments.

@hr1sh1kesh hr1sh1kesh closed this Feb 2, 2018
@hr1sh1kesh
Copy link
Contributor Author

Closing and opening another one with a lot more code addition

@matanbaruch matanbaruch mentioned this pull request Mar 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-px harsh-px harsh-px requested changes

Assignees

@hr1sh1kesh hr1sh1kesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop a Helm chart which would ease the deployment of Portworx
2 participants
@hr1sh1kesh @harsh-px